This is an archive of the discontinued LLVM Phabricator instance.

[Tsan] Add FreeBSD support to longjmp-related definitions
ClosedPublic

Authored by kutuzov.viktor.84 on Oct 18 2014, 2:50 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Tsan] Add FreeBSD support to longjmp-related definitions.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov, glider.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.

Looks reasonable to me, but I'll let Dmitry sign this off.

dvyukov accepted this revision.Oct 21 2014, 12:34 AM
dvyukov edited edge metadata.

LGTM with a nit

lib/tsan/rtl/tsan_interceptors.cc
426 ↗(On Diff #15118)

You already pass the same value in both RSI and RDI, so revert changes to this function.

This revision is now accepted and ready to land.Oct 21 2014, 12:34 AM
Diffusion closed this revision.Oct 21 2014, 6:48 AM
Diffusion updated this revision to Diff 15184.

Closed by commit rL220292 (authored by vkutuzov).