This is an archive of the discontinued LLVM Phabricator instance.

Remove LoopVectorizationCostModel::AT
ClosedPublic

Authored by ehsan on Oct 14 2014, 4:38 PM.

Details

Summary

This triggers an unused private field warning.

Diff Detail

Event Timeline

ehsan updated this revision to Diff 14903.Oct 14 2014, 4:38 PM
ehsan retitled this revision from to Remove LoopVectorizationCostModel::AT.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: rafael.
ehsan added a subscriber: Unknown Object (MLST).

Is the warning emitted in a +Asserts build of LLVM? (usually such warnings don't persist long in the codebase, because so many of us build with -Werror +Asserts, so that leaves the clang warnings for -Asserts builds, but you have to be careful that you don't break the +Asserts build when you fix these (eg: the variable may be unused in -Asserts, but used in +Asserts, so removing it will fix the -Asserts warning, but break the +Asserts build))

I've committed this in r219749.

ehsan accepted this revision.Oct 14 2014, 5:19 PM
ehsan added a reviewer: ehsan.

Thanks :)

This revision is now accepted and ready to land.Oct 14 2014, 5:19 PM
ehsan closed this revision.Oct 14 2014, 5:19 PM