This is an archive of the discontinued LLVM Phabricator instance.

Power-specific fastisel test case updates for VSX
ClosedPublic

Authored by seurer on Oct 14 2014, 11:57 AM.

Details

Summary

These 5 Power-specific test cases fail with VSX support turned on. Originally they failed because fastisel does not support VSX registers and when one was encountered some "unexpected register class" assertions were triggered. Now they fail because fastisel returns that it could not handle things (see http://reviews.llvm.org/D5362) and they specify the -fast-isel-abort option. All this patch does is to specify -mattr=-vsx as a new option. Eventually we will want to remove this when fastisel fully supports VSX.

Diff Detail

Event Timeline

seurer updated this revision to Diff 14873.Oct 14 2014, 11:57 AM
seurer retitled this revision from to Power-specific fastisel test case updates for VSX.
seurer updated this object.
seurer edited the test plan for this revision. (Show Details)
seurer added reviewers: echristo, hfinkel, wschmidt.
seurer added a subscriber: Unknown Object (MLST).
wschmidt edited edge metadata.Oct 14 2014, 12:41 PM

typo: "-fast-isel-abourt" in all the tests. Otherwise this is fine from my standpoint.

seurer updated this revision to Diff 14883.Oct 14 2014, 12:56 PM
seurer edited edge metadata.
wschmidt accepted this revision.Oct 16 2014, 7:00 PM
wschmidt edited edge metadata.

These changes are harmless and will help keep the failure list down as we work on enabling VSX. As discussed in http://reviews.llvm.org/D5362, true VSX support for FastISel is planned, at which time VSX-specific tests (or variants of these tests) will be added. The patch LGTM -- I'll plan to commit on Bill Seurer's behalf tomorrow night if nobody objects.

This revision is now accepted and ready to land.Oct 16 2014, 7:00 PM
wschmidt closed this revision.Oct 19 2014, 2:00 PM

I committed this as r220172 today. I took the liberty of reflowing the comments because they were wider than 80 columns -- very naughty! /fingerwag