This is an archive of the discontinued LLVM Phabricator instance.

llvm-mc & llc tools hang if no input arguments are present
AbandonedPublic

Authored by jyoti.allur on Oct 10 2014, 6:44 AM.

Details

Summary

Hello,

llvm-mc & llc tools hang if no input arguments are present, until ctrlC is used to get the command prompt back.
New developers many not know about these tool's usage. Hence the fix.
Could you please help review it.

Thanks.

Diff Detail

Event Timeline

jyoti.allur retitled this revision from to llvm-mc & llc tools hang if no input arguments are present.
jyoti.allur updated this object.
jyoti.allur edited the test plan for this revision. (Show Details)
jyoti.allur added reviewers: rafael, echristo.
jyoti.allur set the repository for this revision to rL LLVM.
jyoti.allur added a subscriber: Unknown Object (MLST).
jyoti.allur updated this object.Oct 10 2014, 6:46 AM
rafael edited edge metadata.Oct 10 2014, 7:19 AM

This will break

./bin/llc < ~/llvm/test.ll

no?

jyoti.allur added a comment.EditedOct 10 2014, 8:46 AM

Yes, it breaks, i hadn't considered file redirection.

asl added a subscriber: asl.Oct 15 2014, 11:56 PM

Please run LLVM tests before submitting any patches.

jyoti.allur abandoned this revision.EditedOct 16 2014, 3:19 AM

sorry, my fault. Abandoning this patch as parsing the argv[] strings to check if there is a redirection operator is not worthy of the end result.