This is an archive of the discontinued LLVM Phabricator instance.

Add codegen for minnum / magnum
ClosedPublic

Authored by arsenm on Oct 9 2014, 7:16 PM.

Details

Reviewers
hfinkel

Diff Detail

Event Timeline

arsenm updated this revision to Diff 14697.Oct 9 2014, 7:16 PM
arsenm retitled this revision from to Add codegen for minnum / magnum.
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
arsenm updated this revision to Diff 15213.Oct 21 2014, 2:46 PM

Update for trunk

hfinkel accepted this revision.Oct 21 2014, 3:10 PM
hfinkel added a reviewer: hfinkel.
hfinkel added a subscriber: hfinkel.

LGTM, thanks!

I recall there being some discussion on the mailing list regarding the proper name for these intrinsics. When you commit, please repeat the rationale for the current names and semantics in the commit message.

This revision is now accepted and ready to land.Oct 21 2014, 3:10 PM
arsenm closed this revision.Oct 21 2014, 4:11 PM

r220342 with the test files renamed to match the new names