This is an archive of the discontinued LLVM Phabricator instance.

Add minnum / maxnum intrinsics
ClosedPublic

Authored by arsenm on Oct 9 2014, 7:15 PM.

Details

Reviewers
hfinkel

Diff Detail

Event Timeline

arsenm updated this revision to Diff 14696.Oct 9 2014, 7:15 PM
arsenm retitled this revision from to Add minnum / maxnum intrinsics.
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
arsenm updated this revision to Diff 15212.Oct 21 2014, 2:45 PM

Update for trunk

hfinkel accepted this revision.Oct 21 2014, 3:09 PM
hfinkel added a reviewer: hfinkel.
hfinkel added a subscriber: hfinkel.

LGTM, thanks!

lib/Transforms/InstCombine/InstCombineCalls.cpp
551

I believe this to be correct, we cannot return undef because we're prohibited from making the output NaN (even if the input is NaN so long as both inputs are not NaN). But please add a comment explaining this.

This revision is now accepted and ready to land.Oct 21 2014, 3:09 PM
arsenm closed this revision.Oct 21 2014, 4:11 PM

r220341