[Tsan] Fix the getline_nohang.cc test to build on FreeBSD

[glider]

test/tsan/getline_nohang.cc

5 ↗

(On Diff #14560)

Isn't "#ifdef FreeBSD" more common? (that doesn't make much difference however)

I've also noticed other #ifdef's for OpenBSD, DragonFlyBSD, NetBSD etc. in the codebase. Do you know if they also apply here?

[emaste]

test/tsan/getline_nohang.cc

5 ↗

(On Diff #14560)

Isn't "#ifdef FreeBSD" more common?

That's the style I would use, fwiw.

I've also noticed other #ifdef's for OpenBSD, DragonFlyBSD, NetBSD etc. in the codebase. Do you know if they also apply here?

There's going to be a lot of tedious comparison work to be done to make this work across all *BSDs.

On the LLDB list we had a short discussion on having a general *BSD define, but did not reach a conclusion. My take is that there's not a lot of value in adding other BSD defines for a small handful of cases (like this one, perhaps) if the overall functionality is nowhere near complete.

[kutuzov.viktor.84]

Isn't "#ifdef FreeBSD" more common? (that doesn't make much difference however)

Yes, a typo. Thanks.

I've also noticed other #ifdef's for OpenBSD, DragonFlyBSD, NetBSD etc. in the codebase. Do you know if they also apply here?

Well, I don't. But even if I knew it, I would propose we do not respect them in this diff.

[kutuzov.viktor.84]

#if replaced with #ifdef.

[glider]

LGTM

Closed by commit rL219482 (authored by vkutuzov).

compiler-rt/trunk/test/tsan/getline_nohang.cc

 // RUN: %clangxx_tsan -O1 %s -o %t && %run %t
 
 // Make sure TSan doesn't deadlock on a file stream lock at program shutdown.
 // See https://code.google.com/p/thread-sanitizer/issues/detail?id=47
+#ifdef __FreeBSD__
+#define _WITH_GETLINE  // to declare getline()
+#endif
+
 #include <pthread.h>
 #include <stdio.h>
 #include <unistd.h>
 
 void *thread(void *unused) {
   char *line = NULL;
   size_t size;
   int fd[2];