Run profile tests on FreeBSD

[emaste]

Summary

FreeBSD does not have libdl, so set it via lit.cfg as with asan. Add FreeBSD to the list of hosts to test.

[emaste]

Use libdl only on Linux as suggested by Joerg S.

-ldl is unnecessary but harmless on OS X; with this 2nd change it will no longer be added there.

[emaste]

test/profile/lit.cfg

47 ↗

(On Diff #14516)

(accidental shuffling here - should be in alpha order)

[emaste]

Diff against correct base version

[samsonov]

test/profile/lit.cfg

28 ↗

(On Diff #14517)

I believe you should actually use extra_linkflags somewhere (e.g. in build_invocation).

[emaste]

Fix use of extra_linkflags as noted by Alexey Samsonov

Note, this change means that we'll add -ldl to all tests on Linux. This already happens for asan and I don't think it's a problem.

[samsonov]

Yeah, I don't think adding -ldl is a big deal.

[emaste]

Closed by commit rL219227 (authored by @emaste).

compiler-rt/trunk/test/profile/instrprof-dlopen.test

 RUN: mkdir -p %t.d
 RUN: %clang_profgen -o %t.d/func.shared -fPIC -shared %S/Inputs/instrprof-dlopen-func.c
 RUN: %clang_profgen -o %t.d/func2.shared -fPIC -shared %S/Inputs/instrprof-dlopen-func2.c
-RUN: %clang -o %t-local -fPIC -DDLOPEN_FUNC_DIR=\"%t.d\" -DDLOPEN_FLAGS="RTLD_LAZY | RTLD_LOCAL" %S/Inputs/instrprof-dlopen-main.c -ldl
-RUN: %clang -o %t-global -fPIC -DDLOPEN_FUNC_DIR=\"%t.d\" -DDLOPEN_FLAGS="RTLD_LAZY | RTLD_GLOBAL" %S/Inputs/instrprof-dlopen-main.c -ldl
+RUN: %clang -o %t-local -fPIC -DDLOPEN_FUNC_DIR=\"%t.d\" -DDLOPEN_FLAGS="RTLD_LAZY | RTLD_LOCAL" %S/Inputs/instrprof-dlopen-main.c
+RUN: %clang -o %t-global -fPIC -DDLOPEN_FUNC_DIR=\"%t.d\" -DDLOPEN_FLAGS="RTLD_LAZY | RTLD_GLOBAL" %S/Inputs/instrprof-dlopen-main.c
 
 RUN: %clang -c -o %t.d/main.o %S/Inputs/instrprof-dlopen-main.c
 RUN: %clang_profgen -o %t-static %S/Inputs/instrprof-dlopen-func.c %S/Inputs/instrprof-dlopen-func2.c %t.d/main.o
 
 RUN: env LLVM_PROFILE_FILE=%t-static.profraw %run %t-static
 RUN: env LLVM_PROFILE_FILE=%t-local.profraw %run %t-local
 RUN: env LLVM_PROFILE_FILE=%t-global.profraw %run %t-global
 

compiler-rt/trunk/test/profile/lit.cfg

if config.test_exec_root is None:
     # The magic relies on knowing compilerrt_site_basedir.
     compilerrt_basedir = lit_config.params.get('compilerrt_site_basedir', None)
     if compilerrt_basedir:
         site_cfg = os.path.join(compilerrt_basedir, 'profile', 'lit.site.cfg')
         if os.path.exists(site_cfg):
             lit_config.load_config(config, site_cfg)
             raise SystemExit
 
+if config.host_os in ['Linux']:
+  extra_linkflags = ["-ldl"]
+else:
+  extra_linkflags = []
+
 # Test suffixes.
 config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm', '.ll', '.test']
 
 # What to exclude.
 config.excludes = ['Inputs']
 
 # Clang flags.
-clang_cflags = [config.target_cflags]
+clang_cflags = [config.target_cflags] + extra_linkflags
 
 def build_invocation(compile_flags):
   return " " + " ".join([config.clang] + compile_flags) + " "
 
 # Add clang substitutions.
 config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) )
 config.substitutions.append( ("%clang_profgen ", build_invocation(clang_cflags) + " -fprofile-instr-generate ") )
 config.substitutions.append( ("%clang_profuse=", build_invocation(clang_cflags) + " -fprofile-instr-use=") )
 
-# Profile tests are currently supported on Linux and Darwin only.
-if config.host_os not in ['Linux', 'Darwin']:
+if config.host_os not in ['Darwin', 'FreeBSD', 'Linux']:
   config.unsupported = True