This is an archive of the discontinued LLVM Phabricator instance.

[test-suite][mips] Disable setlocale calls in consumer-typeset test
ClosedPublic

Authored by mstojanovic on Dec 14 2018, 9:02 AM.

Details

Summary

When running the test-suite through qemu an error can occur when the host and target architecture differ in endianness. This happens when the test calls setlocale. The glibc implementation of this call reads /usr/lib/locale/locale-archive as raw bites. Since the endianness doesn't match, the numbers read from the archive don't make sense and cause the check to fail.
This patch disables the setlocale call so the test passes regardless of endianness.

Diff Detail

Repository
rL LLVM

Event Timeline

mstojanovic created this revision.Dec 14 2018, 9:02 AM
atanasyan accepted this revision.Dec 20 2018, 6:41 AM

LGTM

Do you have commit access?

This revision is now accepted and ready to land.Dec 20 2018, 6:41 AM

I don't have commit access so @petarj usually does the commits. Thanks for the review.

This revision was automatically updated to reflect the committed changes.