This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix installation of ABI headers. Fixes PR20936
ClosedPublic

Authored by EricWF on Sep 22 2014, 9:10 PM.

Details

Summary

I changed the build so that each ABI header gets its own install rule. This gives us the flexibility to install different headers in different directories.
This also fixes the problem where libstdc++ bits/<header>'s were not being installed under a bits directory.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 13966.Sep 22 2014, 9:10 PM
EricWF retitled this revision from to [libcxx] Fix installation of ABI headers. Fixes PR20936.
EricWF updated this object.
EricWF edited the test plan for this revision. (Show Details)
EricWF added reviewers: mclow.lists, danalbert, jroelofs.
EricWF added a subscriber: Unknown Object (MLST).

Successfully tested on Linux with libc++ using libsupc++.

mclow.lists edited edge metadata.Sep 23 2014, 6:56 AM

I'm ok with this.

jroelofs accepted this revision.Sep 23 2014, 7:41 AM
jroelofs edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 23 2014, 7:41 AM
EricWF closed this revision.Sep 23 2014, 7:52 AM