This is an archive of the discontinued LLVM Phabricator instance.

R600/SI: Remove apparently dead code in legalizeOperands
ClosedPublic

Authored by arsenm on Sep 19 2014, 4:36 PM.

Download Raw Diff

Details

Reviewers

Summary

No tests hit this, and I don't see any way a GlobalAddress
node would survive beyond lowering on SI. It it would,
this should probably be inserted by selection.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 13898.Sep 19 2014, 4:36 PM

arsenm retitled this revision from to R600/SI: Remove apparently dead code in legalizeOperands .

arsenm updated this object.

arsenm edited the test plan for this revision. (Show Details)

arsenm added a subscriber: Unknown Object (MLST).

arsenm accepted this revision.Oct 7 2014, 2:19 PM

arsenm added a reviewer: arsenm.

This revision is now accepted and ready to land.Oct 7 2014, 2:19 PM

arsenm closed this revision.Oct 7 2014, 2:19 PM

Revision Contents

Path

Size

lib/

Target/

R600/

SIISelLowering.cpp

8 lines

Diff 13898

lib/Target/R600/SIISelLowering.cpp

Context not available.
	ensureSRegLimit(DAG, Ops[i], RegClass, ScalarSlotUsed);	ensureSRegLimit(DAG, Ops[i], RegClass, ScalarSlotUsed);
	}	}
	continue;	continue;
	} else {
	// If it's not a VSrc or SSrc operand check if we have a GlobalAddress.
	// These will be lowered to immediates, so we will need to insert a MOV.
	if (isa<GlobalAddressSDNode>(Ops[i])) {
	SDNode *Node = DAG.getMachineNode(AMDGPU::V_MOV_B32_e32, SDLoc(),
	Operand.getValueType(), Operand);
	Ops[i] = SDValue(Node, 0);
	}
	}	}

	if (i == 1 && DescRev && fitsRegClass(DAG, Ops[0], RegClass)) {	if (i == 1 && DescRev && fitsRegClass(DAG, Ops[0], RegClass)) {
Context not available.