This is an archive of the discontinued LLVM Phabricator instance.

Introduce support for custom wrappers for vararg functions
ClosedPublic

Authored by martignlo on Sep 19 2014, 6:46 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

martignlo updated this revision to Diff 13866.Sep 19 2014, 6:46 AM
martignlo retitled this revision from to Introduce support for custom wrappers for vararg functions.
martignlo updated this object.
martignlo edited the test plan for this revision. (Show Details)
martignlo added a reviewer: pcc.
martignlo set the repository for this revision to rL LLVM.
pcc added a subscriber: Unknown Object (MLST).Sep 19 2014, 1:56 PM
pcc added inline comments.
lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
1360 ↗(On Diff #13866)

Can you give this a different name to avoid shadowing by the other FT on line 1394?

1413 ↗(On Diff #13866)

Can't you just use CS.arg_size() here?

1434 ↗(On Diff #13866)

Likewise.

pcc accepted this revision.Sep 26 2014, 10:05 AM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 26 2014, 10:05 AM
martignlo closed this revision.Sep 30 2014, 5:43 AM
martignlo updated this revision to Diff 14219.

Closed by commit rL218671 (authored by @martignlo).