This is an archive of the discontinued LLVM Phabricator instance.

Differential D5371

[zorg] Fix the LibcxxAndAbiBuilder's passing of LIT arguments
ClosedPublic

Authored by jroelofs on Sep 16 2014, 1:14 PM.

Details

Reviewers
danalbert
jroelofs
Summary

This removes a set of quotes that was causing lit.py to barf.

Diff Detail

Event Timeline

jroelofs updated this revision to Diff 13760.Sep 16 2014, 1:14 PM
jroelofs retitled this revision from to [zorg] Fix the LibcxxAndAbiBuilder's passing of LIT arguments.
jroelofs updated this object.
jroelofs edited the test plan for this revision. (Show Details)
jroelofs added a reviewer: danalbert.
jroelofs added a subscriber: Unknown Object (MLST).
danalbert accepted this revision.Sep 16 2014, 1:14 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 16 2014, 1:14 PM
jroelofs accepted this revision.Sep 16 2014, 1:15 PM
jroelofs closed this revision.
jroelofs added a reviewer: jroelofs.

r217896

Revision Contents

PathSize
buildbot/
builders/
2 lines

Diff 13760

buildbot/builders/LibcxxAndAbiBuilder.py

Context not available.
f.addStep(buildbot.steps.shell.ShellCommand( f.addStep(buildbot.steps.shell.ShellCommand(
name='cmake', command=['cmake', src_root, name='cmake', command=['cmake', src_root,
'-DLLVM_LIT_ARGS="'+litTestArgs+'"'], '-DLLVM_LIT_ARGS='+litTestArgs],
haltOnFailure=True, workdir=build_path, env=env)) haltOnFailure=True, workdir=build_path, env=env))
# Build libcxxabi # Build libcxxabi
Context not available.