This is an archive of the discontinued LLVM Phabricator instance.

R600/SI: Add some mubuf testcases.
ClosedPublic

Authored by arsenm on Sep 13 2014, 2:07 PM.

Details

Reviewers
arsenm
Summary

I noticed some odd looking cases where addr64 wasn't set
when storing to a pointer in an SGPR. This seems to be intentional,
and partially tested already.

The documentation seems to describe addr64 in terms of which registers
addressing modifiers come from, but I would expect to always need
addr64 when using 64-bit pointers. If no offset is applied,
it makes sense to not need to worry about doing a 64-bit add
for the final address. A small immediate offset can be applied,
so is it OK to not have addr64 set if a carry is necessary when adding
the base pointer in the resource to the offset?

Diff Detail

Event Timeline

arsenm updated this revision to Diff 13679.Sep 13 2014, 2:07 PM
arsenm retitled this revision from to R600/SI: Add some mubuf testcases. .
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
arsenm accepted this revision.Sep 15 2014, 9:58 AM
arsenm added a reviewer: arsenm.

r217785

This revision is now accepted and ready to land.Sep 15 2014, 9:58 AM
arsenm closed this revision.Sep 15 2014, 9:58 AM