This is an archive of the discontinued LLVM Phabricator instance.

Ignore annotation function calls in cost computation
ClosedPublic

Authored by dpeixott on Sep 12 2014, 10:43 AM.

Details

Summary

The annotation instructions are dropped during codegen and have no
impact on size. In some cases, the annotations were preventing the
unroller from unrolling a loop because the annotation calls were
pushing the cost over the unrolling threshold.

Diff Detail

Event Timeline

dpeixott updated this revision to Diff 13644.Sep 12 2014, 10:43 AM
dpeixott retitled this revision from to Ignore annotation function calls in cost computation.
dpeixott updated this object.
dpeixott added a subscriber: Unknown Object (MLST).
mcrosier accepted this revision.Sep 25 2014, 1:26 PM
mcrosier added a reviewer: chandlerc.
mcrosier added a reviewer: mcrosier.
mcrosier added a subscriber: mcrosier.

Chandler defined this interface, so I'll add him to the review. However, this looks trivially correct, so I'm going to go ahead and approve.

This revision is now accepted and ready to land.Sep 25 2014, 1:26 PM
dpeixott closed this revision.Sep 26 2014, 10:58 AM
dpeixott updated this revision to Diff 14124.

Closed by commit rL218525 (authored by @dpeixott).