[analyzer] move NewDeleteLeaks checker from alpha.cplusplus to cplusplus group.

[ayartsev]

Summary

Once again ran NeweleteLeaks over the LLVM codebase and addressed all leak reports. The majority of them are related to mangling the address of a pointer, several reports are real leaks, the rest are single rare cases.
Is it OK now to turn the checker on?

[ayartsev]

Attached is the report with all the leaks from the last analyzer run (10.09.2014) addressed. Minimal tests are included for all types of false-positives.

NewDeleteLeaks_reports_explained.zip437 KBDownload

[jordan_rose]

Thanks for running the tests! I'm surprised we have trouble with test4.cpp, but the others all do seem like known issues. I'd like to check with Anna or Ted as well before turning this on for real.

lib/StaticAnalyzer/Core/ExprEngineC.cpp

903 ↗

(On Diff #13594)

This snuck in somehow?

[ayartsev]

Cleaned the patch.
Anna, Ted, do you think the NeweleteLeaks checker is ready for being turned on?

[zaks.anna]

Anton,

Have you tested this on any C++ codebase other than LLVM? It would be really great to confirm the results by testing this on a different project.

[ayartsev]

Hi all,

Currently managed to launch the analyzer only on the Ogre
(http://www.ogre3d.org/download/source) codebase using different hacks
and tricks. The analyzer found a single leak - a known type of
false-positives related to the bit mangling. Attached is the report from
the analyzer. I think it's a good result as Ogre extensively allocates
memory in different ways and we haven't got tons of false-positives. To
ensure that the analyzer works correctly I injected a leaky code in the
Ogre codebase and the analyzer successfully found it.

The last weeks I'm trying to launch the analyzer on the QT5 codebase.
Currently found at least 4 defects in the scan-build/ccc-analyzer
scripts preventing me from successful run. Also tried to launch the
analyzer over several small projects but failed. The scan-build is far
from being production-quality. Currently working on the defects.

Anton,

Have you tested this on any C++ codebase other than LLVM? It would be really great to confirm the results by testing this on a different project.

http://reviews.llvm.org/D5313

[zaks.anna]

Anton,

Thank you for running the extra tests! Please, go ahead and turn on the checker when you are ready.

Thank you,
Anna.

[ayartsev]

Committed at r220289.

lib/StaticAnalyzer/Checkers/Checkers.td

   HelpText<"Check for double-free and use-after-free problems. Traces memory managed by new/delete.">, 
   DescFile<"MallocChecker.cpp">;
 
+def NewDeleteLeaksChecker : Checker<"NewDeleteLeaks">,
+  HelpText<"Check for memory leaks. Traces memory managed by new/delete.">, 
+  DescFile<"MallocChecker.cpp">;
+
 } // end: "cplusplus"
 
 let ParentPackage = CplusplusAlpha in {

   HelpText<"Check virtual function calls during construction or destruction">, 
   DescFile<"VirtualCallChecker.cpp">;
 
-def NewDeleteLeaksChecker : Checker<"NewDeleteLeaks">,
-  HelpText<"Check for memory leaks. Traces memory managed by new/delete.">, 
-  DescFile<"MallocChecker.cpp">;
-
 } // end: "alpha.cplusplus"
 
 //===----------------------------------------------------------------------===//

test/Analysis/Malloc+MismatchedDeallocator+NewDelete.cpp

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,unix.MismatchedDeallocator,cplusplus.NewDelete -std=c++11 -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,unix.MismatchedDeallocator,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks -DLEAKS -std=c++11 -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,unix.MismatchedDeallocator,cplusplus.NewDelete,cplusplus.NewDeleteLeaks -DLEAKS -std=c++11 -verify %s
 
 #include "Inputs/system-header-simulator-for-malloc.h"
 

test/Analysis/Malloc+NewDelete_intersections.cpp

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,cplusplus.NewDelete -std=c++11 -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks -std=c++11 -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,cplusplus.NewDelete,cplusplus.NewDeleteLeaks -std=c++11 -verify %s
 
 typedef __typeof(sizeof(int)) size_t;
 void *malloc(size_t);

test/Analysis/NewDelete+MismatchedDeallocator_intersections.cpp

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,unix.MismatchedDeallocator -std=c++11 -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks,unix.MismatchedDeallocator -DLEAKS -std=c++11 -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,cplusplus.NewDeleteLeaks,unix.MismatchedDeallocator -DLEAKS -std=c++11 -verify %s
 // expected-no-diagnostics
 
 typedef __typeof(sizeof(int)) size_t;

test/Analysis/NewDelete-checker-test.cpp

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete -std=c++11 -fblocks -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.cplusplus.NewDeleteLeaks -DLEAKS -std=c++11 -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDeleteLeaks -DLEAKS -std=c++11 -fblocks -verify %s
 #include "Inputs/system-header-simulator-cxx.h"
 
 typedef __typeof__(sizeof(int)) size_t;

test/Analysis/NewDelete-custom.cpp

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,unix.Malloc -std=c++11 -fblocks -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks,unix.Malloc -std=c++11 -DLEAKS -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,cplusplus.NewDeleteLeaks,unix.Malloc -std=c++11 -DLEAKS -fblocks -verify %s
 #include "Inputs/system-header-simulator-cxx.h"
 
 #ifndef LEAKS

test/Analysis/NewDelete-intersections.mm

 // RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete -std=c++11 -fblocks -verify %s
-// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks -std=c++11 -DLEAKS -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,cplusplus.NewDeleteLeaks -std=c++11 -DLEAKS -fblocks -verify %s
 #include "Inputs/system-header-simulator-cxx.h"
 #include "Inputs/system-header-simulator-objc.h"
 

test/Analysis/NewDelete-variadic.cpp

-// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,alpha.cplusplus.NewDeleteLeaks,unix.Malloc -std=c++11 -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDelete,cplusplus.NewDeleteLeaks,unix.Malloc -std=c++11 -fblocks -verify %s
 // expected-no-diagnostics
 
 namespace std {

test/Analysis/NewDeleteLeaks-PR18394.cpp

-// RUN: %clang_cc1 -analyzer-config graph-trim-interval=1 -analyzer-max-loop 1 -analyze -analyzer-checker=core,alpha.cplusplus.NewDeleteLeaks -verify %s
+// RUN: %clang_cc1 -analyzer-config graph-trim-interval=1 -analyzer-max-loop 1 -analyze -analyzer-checker=core,cplusplus.NewDeleteLeaks -verify %s
 // expected-no-diagnostics
 
 class A {

test/Analysis/NewDeleteLeaks-PR19102.cpp

-// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.cplusplus.NewDeleteLeaks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-checker=core,cplusplus.NewDeleteLeaks -verify %s
 
 class A0 {};