This is an archive of the discontinued LLVM Phabricator instance.

Differential D51819

[clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
ClosedPublic

Authored by benhamilton on Sep 7 2018, 2:48 PM.

Details

Reviewers
Wizard
hokein
Commits
rG8e261351b4fb: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
rG2f0a1286f34b: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
rL341721: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
rCTE341721: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
rCTE341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
rL341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
Summary

This adds a few common acronyms we found were missing from PropertyDeclarationCheck.

Diff Detail

Repository
rL LLVM

Event Timeline

benhamilton created this revision.Sep 7 2018, 2:48 PM
Harbormaster completed remote builds in B22392: Diff 164521.Sep 7 2018, 2:48 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptSep 7 2018, 2:48 PM
hokein accepted this revision.Sep 7 2018, 2:56 PM

We need to update the documentation http://clang.llvm.org/extra/clang-tidy/checks/objc-property-declaration.html as well.

This revision is now accepted and ready to land.Sep 7 2018, 2:56 PM
benhamilton updated this revision to Diff 164523.Sep 7 2018, 3:02 PM
  • Update docs.
Harbormaster completed remote builds in B22393: Diff 164523.Sep 7 2018, 3:05 PM
Closed by commit rL341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck (authored by benhamilton). · Explain WhySep 7 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 7 2018, 3:06 PM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clang-tidy/
objc/
8 lines

Diff 164525

clang-tools-extra/trunk/clang-tidy/objc/PropertyDeclarationCheck.cpp

Show All 36 Lines
/// The acronyms are aggregated from multiple sources including /// The acronyms are aggregated from multiple sources including
/// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20001285-BCIHCGAE /// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20001285-BCIHCGAE
/// ///
/// Keep this list sorted. /// Keep this list sorted.
constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = { constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
"[2-9]G", "[2-9]G",
"ACL", "ACL",
"API", "API",
"APN",
"APNS",
"AR", "AR",
"ARGB", "ARGB",
"ASCII", "ASCII",
"AV", "AV",
"BGRA", "BGRA",
"CA", "CA",
"CDN",
"CF", "CF",
"CG", "CG",
"CI", "CI",
"CRC", "CRC",
"CV", "CV",
"CMYK", "CMYK",
"DNS", "DNS",
"FPS", "FPS",
"FTP", "FTP",
"GIF", "GIF",
"GL", "GL",
"GPS", "GPS",
"GUID", "GUID",
"HD", "HD",
"HDR", "HDR",
"HMAC", "HMAC",
"HTML", "HTML",
"HTTP", "HTTP",
"HTTPS", "HTTPS",
"HUD", "HUD",
"ID", "ID",
"JPG", "JPG",
"JS", "JS",
"JSON",
"LAN", "LAN",
"LZW", "LZW",
"LTR",
"MAC", "MAC",
"MD", "MD",
"MDNS", "MDNS",
"MIDI", "MIDI",
"NS", "NS",
"OS", "OS",
"P2P",
"PDF", "PDF",
"PIN", "PIN",
"PNG", "PNG",
"POI", "POI",
"PSTN", "PSTN",
"PTR", "PTR",
"QA", "QA",
"QOS", "QOS",
"RGB", "RGB",
"RGBA", "RGBA",
"RGBX", "RGBX",
"RIPEMD", "RIPEMD",
"ROM", "ROM",
"RPC", "RPC",
"RTF", "RTF",
"RTL", "RTL",
"SC", "SC",
"SDK", "SDK",
"SHA", "SHA",
"SQL", "SQL",
"SSO", "SSO",
"TCP", "TCP",
"TIFF", "TIFF",
"TOS",
"TTS", "TTS",
"UI", "UI",
"URI", "URI",
"URL", "URL",
"UUID", "UUID",
"VC", "VC",
"VO",
"VOIP", "VOIP",
"VPN", "VPN",
"VR", "VR",
"W", "W",
"WAN", "WAN",
"X", "X",
"XML", "XML",
"Y", "Y",
▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines