This is an archive of the discontinued LLVM Phabricator instance.

Move Host::GetLLDBPath to HostInfo
ClosedPublic

Authored by zturner on Aug 20 2014, 3:47 PM.

Details

Reviewers
zturner
Summary

This continues the effort to get Host code moved over to HostInfo, and removes many more instances of preprocessor defines along the way.

Tested on Linux, Mac, and Windows. Although I think this is safe, the movement was slightly more complex than normal, so if anyone feels the need to test on iOS or some other configuration that isn't tested by the default test suite on Linux / MacOSX, feel free. Will submit tomorrow otherwise.

Diff Detail

Event Timeline

zturner updated this revision to Diff 12715.Aug 20 2014, 3:47 PM
zturner retitled this revision from to Move Host::GetLLDBPath to HostInfo.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a subscriber: Unknown Object (MLST).
zturner updated this revision to Diff 12716.Aug 20 2014, 4:05 PM

Make HostInfo::GetLLDBPath() a little cleaner.

zturner accepted this revision.Aug 22 2014, 11:28 AM
zturner added a reviewer: zturner.

This CL was submitted.

This revision is now accepted and ready to land.Aug 22 2014, 11:28 AM
zturner closed this revision.Aug 22 2014, 11:28 AM