This is an archive of the discontinued LLVM Phabricator instance.

Add FreeBSD 9 support to libcxxabi testing framework
AbandonedPublic

Authored by danalbert on Aug 15 2014, 4:13 AM.

Details

Diff Detail

Event Timeline

kutuzov.viktor.84 retitled this revision from to Add FreeBSD 9 support to libcxxabi testing framework.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a reviewer: danalbert.
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
kutuzov.viktor.84 added a subscriber: emaste.
emaste requested changes to this revision.Aug 15 2014, 9:00 AM
emaste added a reviewer: emaste.
emaste added inline comments.
test/lit.cfg
204

Use sys.platform.startswith('freebsd') instead, so that we don't get "unrecognized system" on FreeBSD 10.

See http://bugs.python.org/issue12326 and http://bugs.python.org/issue12795 for the sad details :(

This revision now requires changes to proceed.Aug 15 2014, 9:00 AM
EricWF requested changes to this revision.Aug 15 2014, 12:27 PM
EricWF edited edge metadata.

What was this patch generated against? It seems to be against a old and very customized version of lit.cfg.
Please generate the diff against the master. I'm very interested in seeing this patch in master ASAP. However the patch you submitted will not work unless you submit the rest of your changes as well.

Some points:

  • We still need to handle the cxxrt ABI.
  • llvm_unwinder is not set anywhere (in master) but I'm very interested to see it supported.
  • Please add freebsd to the locales table (in master). Here is the change I made to get it working:
'FreeBSD' : {
        'en_US.UTF-8': 'en_US.UTF-8',
        'cs_CZ.ISO8859-2': 'cs_CZ.ISO8859-2',
        'fr_FR.UTF-8': 'fr_FR.UTF-8',
        'fr_CA.ISO8859-1': 'fr_CA.ISO8859-1',
        'ru_RU.UTF-8': 'ru_RU.UTF-8',
        'zh_CN.UTF-8': 'zh_CN.UTF-8',
    },

Thanks for working on this.

I'm a massive colossal idiot. Please ignore everything I just said. I read this as libcxx not libcxxabi. I'm very sorry.

EricWF resigned from this revision.Aug 15 2014, 9:55 PM
EricWF removed a reviewer: EricWF.
danalbert edited edge metadata.Jul 7 2015, 11:41 AM

This patch is obsolete. libcxxabi's test env was updated to match libcxx's months ago.

You can abandon the patch so that it gets removed from outstanding lists.

danalbert commandeered this revision.Aug 12 2015, 9:18 AM
danalbert abandoned this revision.
danalbert edited reviewers, added: kutuzov.viktor.84; removed: danalbert.