This is an archive of the discontinued LLVM Phabricator instance.

Simplify ownership of ExplodedGraph in the CoreEngine by removing unique_ptr indirection.
ClosedPublic

Authored by dblaikie on Aug 8 2014, 4:37 PM.

Details

Summary

I was going to fix the use of raw pointer ownership in "takeGraph" when I realized that function was unused and the whole ExplodedGraph could just be owned by value without the std::unique_ptr indirection at all.

Diff Detail

Event Timeline

dblaikie updated this revision to Diff 12317.Aug 8 2014, 4:37 PM
dblaikie retitled this revision from to Simplify ownership of ExplodedGraph in the CoreEngine by removing unique_ptr indirection..
dblaikie updated this object.
dblaikie added a reviewer: jordan_rose.
dblaikie added a subscriber: Unknown Object (MLST).
jordan_rose accepted this revision.Aug 8 2014, 4:40 PM
jordan_rose edited edge metadata.

That seems entirely reasonable. If we ever need to have ExplodedGraphs persist past the lifetime of the CoreEngine, we can put back something like this. Or make the copy/move constructor efficient!

This revision is now accepted and ready to land.Aug 8 2014, 4:40 PM
dblaikie edited edge metadata.Aug 8 2014, 4:41 PM
dblaikie edited subscribers, added: Unknown Object (MLST); removed: Unknown Object (MLST).
dblaikie closed this revision.Aug 8 2014, 4:45 PM
dblaikie updated this revision to Diff 12318.

Closed by commit rL215257 (authored by @dblaikie).