This is an archive of the discontinued LLVM Phabricator instance.

Support getting process maps for sanitizers needs on FreeBSD in 32-bit mode
ClosedPublic

Authored by kutuzov.viktor.84 on Aug 6 2014, 5:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to Support getting process maps for sanitizers needs on FreeBSD in 32-bit mode.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
samsonov added inline comments.Aug 6 2014, 3:38 PM
lib/sanitizer_common/sanitizer_freebsd.h
103 ↗(On Diff #12230)

why not write

#define kinfo_vmentry xkinfo_vmentry

here?

It would affect definitions in successively included system headers.

samsonov accepted this revision.Aug 7 2014, 11:48 AM
samsonov edited edge metadata.

Okay. LGTM

This revision is now accepted and ready to land.Aug 7 2014, 11:48 AM
kutuzov.viktor.84 updated this revision to Diff 12299.

Closed by commit rL215185 (authored by vkutuzov).