This is an archive of the discontinued LLVM Phabricator instance.

ms-inline-asm: Add a test to ensure that call doesn't clobber eax.
ClosedPublic

Authored by ehsan on Jul 17 2014, 7:21 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

ehsan updated this revision to Diff 11624.Jul 17 2014, 7:21 PM
ehsan retitled this revision from to ms-inline-asm: Add a test to ensure that call doesn't clobber eax..
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: rnk.
ehsan added a subscriber: Unknown Object (MLST).
rnk edited edge metadata.Jul 17 2014, 11:47 PM

Shouldn't it clobber eax?

Why should it? We can't know whether the callee is going to clobber it or not.

rnk added a comment.Jul 29 2014, 5:18 PM

Feel free to commit as a way to codify our current behavior, but I'm not sure it's the right approach. We might want to throw up our hands on control flow and assume it clobbers everything except ebp/esp.

rnk accepted this revision.Jul 29 2014, 5:18 PM
rnk edited edge metadata.

Marking it accepted, for real.

This revision is now accepted and ready to land.Jul 29 2014, 5:18 PM
ehsan closed this revision.Jul 31 2014, 6:52 AM
ehsan updated this revision to Diff 12062.

Closed by commit rL214401 (authored by @ehsan).