Page MenuHomePhabricator

Remove explicit references to libdl from Asan test cases
ClosedPublic

Authored by kutuzov.viktor.84 on Jul 14 2014, 10:17 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to Remove explicit references to libdl from Asan test cases.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
glider added a subscriber: glider.Jul 14 2014, 10:52 AM

Yet there is libdl on Linux, and the existing command line is the correct
way to build tests that use libdl API, isn't it?

Yet there is libdl on Linux, and the existing command line is the correct way to build tests that use libdl API, isn't it?

Well, these are different things:

  • What you refer to as Linux libdl API is available on FreeBSD as well.
  • However, on FreeBSD the implementation of the API is part of libc and not libdl. There is no a library named libdl on FreeBSD.

So, given the test cases refer to libdl explicitly, they cannot be built on FreeBSD. The intention behind this patch is to remove explicit references to libdl from the test cases and apply '-ldl' to all test cases, where necessary.

eugenis accepted this revision.Jul 15 2014, 6:19 AM
eugenis added a reviewer: eugenis.
eugenis added a subscriber: eugenis.

Looks good.

This revision is now accepted and ready to land.Jul 15 2014, 6:19 AM
kutuzov.viktor.84 updated this revision to Diff 11490.

Closed by commit rL213131 (authored by vkutuzov).