This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Add Android support.
ClosedPublic

Authored by danalbert on Jul 9 2014, 4:42 PM.

Details

Reviewers
mclow.lists

Diff Detail

Event Timeline

danalbert updated this revision to Diff 11229.Jul 9 2014, 4:42 PM
danalbert retitled this revision from to [libcxx] Add Android support..
danalbert updated this object.
danalbert edited the test plan for this revision. (Show Details)
danalbert added a reviewer: mclow.lists.
danalbert added a subscriber: Unknown Object (MLST).

This looks good to me, but you should probably wait for Marshall to take a look. It would be nice if you took care of the nits (fwiw, I hate trailing comments on the ifdefs since they are easy to get out of sync).

include/__locale
350

Might be nice to clang-format this line.

include/locale
198

This is no longer very precise (not that it was particularly so before your change).

3678

Update the trailing comment.

3693

Same.

src/locale.cpp
35

Same.

mclow.lists accepted this revision.Jul 10 2014, 8:29 AM
mclow.lists edited edge metadata.

Committed (with minor formatting changes) as revision 212724

This revision is now accepted and ready to land.Jul 10 2014, 8:29 AM
danalbert closed this revision.Jul 10 2014, 3:32 PM