Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

[dpayne]

Summary

When SpacesInParentheses is set to true clang-format does not add a space before a global namespace variable. For example this is the output of clang-format for a somewhat contrived exampled.

#include <iostream>

void print_val( std::ostream &s ) { s << "Hello world" << std::endl; }

int main( void ) {
  print_val(::std::cout );
  return 0;
}

The .clang-format looked like

Language:        Cpp
SpacesInParentheses: true

[dpayne]

Adding a unit test for formatting a global namespace var with SpacesInParentheses enabled.

[djasper]

Please generally upload diffs with the full file as context so that Phabricator can properly expand the context where necessary.

This looks good, though.

[dpayne]

I'll make sure to do the full diff in the future. I did that for the first patch but forgot to do it in the follow up patch, I won't make that mistake in the future.

I do not have commit access so I cannot merge myself. When you have the time could you merge this change?

[dpayne]

Hi

Bumping this commit. I do not have commit access so I cannot merge myself, if you have the time could you merge this commit?

[MyDeveloperDay]

This issue was resolved by https://github.com/llvm/llvm-project/commit/d5e9ff4fe20e66d53a245645c95f0bb816b747cb could you please close out this review

lib/Format/TokenAnnotator.cpp

             Style.Standard == FormatStyle::LS_Cpp03) ||
            !(Left.isOneOf(tok::l_paren, tok::r_paren, tok::l_square,
                           tok::kw___super, TT_TemplateCloser,
-                          TT_TemplateOpener));
+                          TT_TemplateOpener)) ||
+           (Left.is(tok ::l_paren) && Style.SpacesInParentheses);
   if ((Left.is(TT_TemplateOpener)) != (Right.is(TT_TemplateCloser)))
     return Style.SpacesInAngles;
   // Space before TT_StructuredBindingLSquare.

unittests/Format/FormatTest.cpp

   FormatStyle Spaces = getLLVMStyle();
 
   Spaces.SpacesInParentheses = true;
+  verifyFormat("do_something( ::globalVar );", Spaces);
   verifyFormat("call( x, y, z );", Spaces);
   verifyFormat("call();", Spaces);
   verifyFormat("std::function<void( int, int )> callback;", Spaces);