This is an archive of the discontinued LLVM Phabricator instance.

Differential D43844

[profile] Test the exported symbol set for empty programs
ClosedPublic

Authored by vsk on Feb 27 2018, 4:54 PM.

Details

Reviewers
davidxl
vsk
Summary

Programs without any code in them should export the exact same set of
symbols as programs with code, at least on Darwin. This is done to make
text-based API verification possible for certain Darwin frameworks.

Related to: D43794

Diff Detail

Event Timeline

vsk created this revision.Feb 27 2018, 4:54 PM
vsk mentioned this in D43794: [InstrProfiling] Emit the runtime hook when no counters are lowered.
vsk accepted this revision.Feb 28 2018, 11:02 AM

Landed in r326351.

This revision is now accepted and ready to land.Feb 28 2018, 11:02 AM
vsk closed this revision.Feb 28 2018, 11:03 AM

Revision Contents

PathSize
test/
profile/
16 lines

Diff 136195

test/profile/instrprof-darwin-dead-strip.c

// REQUIRES: osx-ld64-live_support // REQUIRES: osx-ld64-live_support
// REQUIRES: lto // REQUIRES: lto
// RUN: %clang_profgen=%t.profraw -fcoverage-mapping -mllvm -enable-name-compression=false -Wl,-dead_strip -o %t %s // RUN: %clang_profgen=%t.profraw -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -Wl,-dead_strip -o %t %s
// RUN: %run %t // RUN: %run %t
// RUN: llvm-profdata merge -o %t.profdata %t.profraw // RUN: llvm-profdata merge -o %t.profdata %t.profraw
// RUN: llvm-profdata show --all-functions %t.profdata | FileCheck %s -check-prefix=PROF // RUN: llvm-profdata show --all-functions %t.profdata | FileCheck %s -check-prefix=PROF
Context not available.
// RUN: otool -s __DATA __llvm_prf_names %t | FileCheck %s -check-prefix=PRF_NAMES // RUN: otool -s __DATA __llvm_prf_names %t | FileCheck %s -check-prefix=PRF_NAMES
// RUN: otool -s __DATA __llvm_prf_cnts %t | FileCheck %s -check-prefix=PRF_CNTS // RUN: otool -s __DATA __llvm_prf_cnts %t | FileCheck %s -check-prefix=PRF_CNTS
// RUN: %clang_lto_profgen=%t.lto.profraw -fcoverage-mapping -mllvm -enable-name-compression=false -Wl,-dead_strip -flto -o %t.lto %s // RUN: %clang_lto_profgen=%t.lto.profraw -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -Wl,-dead_strip -flto -o %t.lto %s
// RUN: %run %t.lto // RUN: %run %t.lto
// RUN: llvm-profdata merge -o %t.lto.profdata %t.lto.profraw // RUN: llvm-profdata merge -o %t.lto.profdata %t.lto.profraw
// RUN: llvm-profdata show --all-functions %t.lto.profdata | FileCheck %s -check-prefix=PROF // RUN: llvm-profdata show --all-functions %t.lto.profdata | FileCheck %s -check-prefix=PROF
Context not available.
// Note: We expect foo() and some of the profiling data associated with it to // Note: We expect foo() and some of the profiling data associated with it to
// be dead-stripped. // be dead-stripped.
// Note: When there is no code in a program, we expect to see the exact same
// set of external functions provided by the profile runtime.
// RUN: %clang_profgen -fcoverage-mapping -Wl,-dead_strip -dynamiclib -o %t.nocode.dylib %s
// RUN: nm -jgU %t.nocode.dylib > %t.nocode.syms
// RUN: nm -jgU %t | grep -vE "main|foo|mh_execute_header" > %t.code.syms
// RUN: diff %t.nocode.syms %t.code.syms
#ifdef CODE
// COV: [[@LINE+1]]{{ *}}|{{ *}}0|void foo() // COV: [[@LINE+1]]{{ *}}|{{ *}}0|void foo()
void foo() {} void foo() {}
// COV: [[@LINE+1]]{{ *}}|{{ *}}1|int main // COV: [[@LINE+1]]{{ *}}|{{ *}}1|int main
int main() { return 0; } int main() { return 0; }
#endif // CODE
// NM-NOT: foo // NM-NOT: foo
// PROF: Counters: // PROF: Counters:
Context not available.