This is an archive of the discontinued LLVM Phabricator instance.

Allow the path to the compiler to have spaces in it when running python test suite
AbandonedPublic

Authored by zturner on Jul 2 2014, 11:16 AM.

Details

Reviewers
tfiala
Summary

On Windows, the path to the compiler almost always contains a space. Previously, we would just replace all spaces with semicolons to build a CMake list. This patch changes the CMake to not do this replacement in the compiler path.

Diff Detail

Event Timeline

zturner updated this revision to Diff 11032.Jul 2 2014, 11:16 AM
zturner retitled this revision from to Allow the path to the compiler to have spaces in it when running python test suite.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: tfiala.
zturner added a subscriber: Unknown Object (MLST).
tfiala edited edge metadata.Jul 17 2014, 10:13 AM

This looks reasonable. I'll give it a run over here...

tfiala accepted this revision.Jul 17 2014, 10:37 AM
tfiala edited edge metadata.

LGTM. Came back clean on Linux x86_64 cmake, Ubuntu 14.04 LTS, cmake-built lldb and cmake for test run compiler.

This revision is now accepted and ready to land.Jul 17 2014, 10:37 AM

I'm going to hold off on submitting this. I had forgotten about it, and I
now have a better idea about how to solve the problem. I want to change
the command line format of dosep.py so that it doesn't take an argument of
the form -o "<command line for dotest.py>" and instead take a -- separator,
and everything after the -- is the command line to pass to dotest.py. This
way there's no need to escape the quotes.

If this turns out to be difficult or annoying I may revisit this patch and
submit it.

zturner abandoned this revision.Jul 22 2014, 9:36 AM

Abandoning this revision since it seems to be heading in the wrong direction. Will address this in a different way in the future.