Page MenuHomePhabricator

[clangd] Fix link failures for Preprocessor::addCommentHandler
ClosedPublic

Authored by aheejin on Feb 18 2018, 12:22 AM.

Details

Summary

D42640 adds calls to Preprocessor::addCommentHandler in
unittests/clangd/SymbolCollectorTests.cpp and
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp but does not
link clangLex library. This causes undefined reference errors when
built with -DBUILD_SHARED_LIBS=ON.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Feb 18 2018, 12:22 AM
ioeric accepted this revision.Feb 18 2018, 2:37 AM
ioeric added a subscriber: malaperle.

lg. Thanks!

fyi, @malaperle also sent D43429 for the same fix but has not landed it yet ;)

This revision is now accepted and ready to land.Feb 18 2018, 2:37 AM
aheejin retitled this revision from Fix link failures for Preprocessor::addCommentHandler to [clangd] Fix link failures for Preprocessor::addCommentHandler.Feb 18 2018, 2:48 AM
This revision was automatically updated to reflect the committed changes.