This is an archive of the discontinued LLVM Phabricator instance.

Fix .seh_stackalloc 0
ClosedPublic

Authored by vadimcn on Jun 27 2014, 8:13 PM.

Details

Summary

seh_stackalloc 0 is not representable in Win64 SEH info, so emitting it is a bug.

Diff Detail

Event Timeline

vadimcn updated this revision to Diff 10955.Jun 27 2014, 8:13 PM
vadimcn retitled this revision from to Fix .seh_stackalloc 0.
vadimcn updated this object.
vadimcn edited the test plan for this revision. (Show Details)
vadimcn set the repository for this revision to rL LLVM.
vadimcn added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Jun 30 2014, 5:38 PM
rnk edited edge metadata.

lgtm, I can commit this.

lib/MC/MCStreamer.cpp
518–519

MCStreamer needs a way to report errors.... :(

This revision is now accepted and ready to land.Jun 30 2014, 5:38 PM
rnk added a comment.Jun 30 2014, 5:39 PM

I'll add a test for this.

vadimcn closed this revision.Dec 4 2014, 5:57 PM

This was committed by @rnk in r212081.