This is an archive of the discontinued LLVM Phabricator instance.

Fix building InstrProfilingFile.c on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Jun 11 2014, 9:55 AM.

Details

Reviewers
joerg
Summary

The removed #include is unnecessary as InstrProfiling.h takes care about declaring corresponding types either by #including <stdint.h> or by declaring them explicitly, which is the case for FreeBSD.

Diff Detail

Event Timeline

kutuzov.viktor.84 retitled this revision from to Fix building InstrProfilingFile.c on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a reviewer: joerg.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.

Related commit: rL209214.

lib/profile/InstrProfilingFile.c
92

Is this file intended to be translated in a pre-C99 mode when mixed declarations and code are not permitted?

joerg edited edge metadata.Jun 11 2014, 10:42 AM

LGTM. No, I don't think we want to restrict ourselves to pre-C99.

joerg accepted this revision.Jun 11 2014, 10:45 AM
joerg edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2014, 10:45 AM
kutuzov.viktor.84 added a comment.EditedJun 15 2014, 7:10 AM

Committed as rL210989.

joerg closed this revision.Jul 29 2014, 5:41 AM

Either applied or no longer relevant.