Page MenuHomePhabricator
Differential D39936

[OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short
ClosedPublic
Actions

Authored by AlexeySotkin on Nov 10 2017, 11:28 PM.

Details

Reviewers
yaxunl
Anastasia
bader
Commits
rGb833bf6ae14f: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short
rC319011: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short
rL319011: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

Diff Detail

Event Timeline

AlexeySotkin created this revision.Nov 10 2017, 11:28 PM
Anastasia added inline comments.Nov 13 2017, 5:35 AM
lib/Headers/opencl-c.h
16128

Any advantage to use these macros here? They will complicate understanding of errors because preprocessor will remove information about the original BIFs being called in the source code.

AlexeySotkin updated this revision to Diff 123716.Nov 20 2017, 11:04 PM

Replacing #define macros with explicit declarations

Anastasia accepted this revision.Nov 22 2017, 9:51 AM

LGTM! Thanks!

This revision is now accepted and ready to land.Nov 22 2017, 9:51 AM
bader accepted this revision.Nov 23 2017, 3:22 AM

LGTM. Thanks!

AlexeySotkin added a comment.Nov 23 2017, 3:27 AM
This comment was removed by AlexeySotkin.
AlexeySotkin closed this revision.Nov 27 2017, 1:14 AM

Revision Contents
Changeset List

PathSize
include/
clang/
Basic/
4 lines
lib/
Headers/
307 lines
test/
SemaOpenCL/
18 lines

Diff 123716

View Options

include/clang/Basic/OpenCLExtensions.def

Loading...
View Options

lib/Headers/opencl-c.h

Loading...
View Options

test/SemaOpenCL/extension-version.cl

Loading...