This is an archive of the discontinued LLVM Phabricator instance.

Differential D3968

ARMEB: Fix function return type f64
ClosedPublic

Authored by cpirker on May 30 2014, 9:36 AM.

Download Raw Diff

Details

Reviewers

t.p.northover

Summary

Hi all,

This patch implements the correct word order to load f64 from stack location and return it as function return value.
Please review.

Thanks,
Christian

Diff Detail

Event Timeline

cpirker updated this revision to Diff 9962.May 30 2014, 9:36 AM

cpirker retitled this revision from to ARMEB: Fix function return type f64.

cpirker updated this object.

cpirker edited the test plan for this revision. (Show Details)

cpirker added subscribers: Unknown Object (MLST), Konrad.

Herald added a subscriber: aemerson. · View Herald TranscriptMay 30 2014, 9:36 AM

Hi Christian,

This looks good to me.

Cheers.

Tim.

This revision is now accepted and ready to land.May 30 2014, 11:34 AM

I committed this patch as rL209990.

Revision Contents

Path

Size

lib/

Target/

ARM/

ARMISelLowering.cpp

2 lines

test/

CodeGen/

ARM/

big-endian-ret-f64.ll

12 lines

Diff 9962

lib/Target/ARM/ARMISelLowering.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 8,309 Lines • ▼ Show 20 Lines	if (ISD::isNormalLoad(InNode) && InNode->hasOneUse() &&
SDValue OffsetPtr = DAG.getNode(ISD::ADD, DL, MVT::i32, BasePtr,		SDValue OffsetPtr = DAG.getNode(ISD::ADD, DL, MVT::i32, BasePtr,
DAG.getConstant(4, MVT::i32));		DAG.getConstant(4, MVT::i32));
SDValue NewLD2 = DAG.getLoad(MVT::i32, DL, NewLD1.getValue(1), OffsetPtr,		SDValue NewLD2 = DAG.getLoad(MVT::i32, DL, NewLD1.getValue(1), OffsetPtr,
LD->getPointerInfo(), LD->isVolatile(),		LD->getPointerInfo(), LD->isVolatile(),
LD->isNonTemporal(), LD->isInvariant(),		LD->isNonTemporal(), LD->isInvariant(),
std::min(4U, LD->getAlignment() / 2));		std::min(4U, LD->getAlignment() / 2));

DAG.ReplaceAllUsesOfValueWith(SDValue(LD, 1), NewLD2.getValue(1));		DAG.ReplaceAllUsesOfValueWith(SDValue(LD, 1), NewLD2.getValue(1));
		if (DCI.DAG.getTargetLoweringInfo().isBigEndian())
		std::swap (NewLD1, NewLD2);
SDValue Result = DCI.CombineTo(N, NewLD1, NewLD2);		SDValue Result = DCI.CombineTo(N, NewLD1, NewLD2);
DCI.RemoveFromWorklist(LD);		DCI.RemoveFromWorklist(LD);
DAG.DeleteNode(LD);		DAG.DeleteNode(LD);
return Result;		return Result;
}		}

return SDValue();		return SDValue();
}		}
▲ Show 20 Lines • Show All 2,465 Lines • Show Last 20 Lines

test/CodeGen/ARM/big-endian-ret-f64.ll

				; RUN: llc -mtriple=armebv7a-eabi %s -O0 -o - \| FileCheck %s
				; RUN: llc -mtriple=armebv8a-eabi %s -O0 -o - \| FileCheck %s

				define double @fn() {
				; CHECK-LABEL: fn
				; CHECK: ldr r0, [sp]
				; CHECK: ldr r1, [sp, #4]
				%r = alloca double, align 8
				%1 = load double* %r, align 8
				ret double %1
				}