This is an archive of the discontinued LLVM Phabricator instance.

Support building floating-point facilities on FreeBSD 9.2 in 32-bit mode
ClosedPublic

Authored by kutuzov.viktor.84 on May 26 2014, 4:05 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to Support building floating-point facilities on FreeBSD 9.2 in 32-bit mode.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste, kcc, samsonov.
scanon added a subscriber: scanon.Jun 10 2014, 9:34 AM

LGTM. I'm no expert on the BSD environment, but this seems perfectly reasonable.

Looks okay to me.

emaste added inline comments.Jun 23 2014, 7:53 AM
lib/builtins/fp_lib.h
33 ↗(On Diff #9800)

Minor point, we may want to use < 903000 for these tests instead (corresponding to the 9.3 release). It's a minor point, but I think more accurately reflects the intent of the test.

For example, a hypothetical 9.2.1 point release would still lack -m32 support in headers, but would have a __FreeBSD_version higher then 902001.

kutuzov.viktor.84 updated this revision to Diff 11144.

Closed by commit rL212518 (authored by vkutuzov).

Committed with the OS version number testing rewritten as suggested by Ed Maste. Thanks, Ed.