This is an archive of the discontinued LLVM Phabricator instance.

MIPS64r6 Relocations R_MIPS_PCHI16, R_MIPS_PCLO16
ClosedPublic

Authored by jkolek on May 21 2014, 5:18 AM.

Details

Summary

Implemented relocations:

  • R_MIPS_PCHI16,
  • R_MIPS_PCLO16.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 9655.May 21 2014, 5:18 AM
jkolek retitled this revision from to MIPS64r6 Relocations R_MIPS_PCHI16, R_MIPS_PCLO16.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, vmedic.
jkolek added a subscriber: zoran.jovanovic.
dsanders accepted this revision.EditedMay 23 2014, 3:25 AM
dsanders edited edge metadata.

LGTM with a nit.

D3824 adds a test file for each relocation. A single relocation.s is slightly preferable since program startup time adds up but we can merge them together later.

test/MC/Mips/mips32r6/relocations.s
22–23

Can you make this stricter? We should be able to test the address, the symbol, and the offset as well.

test/MC/Mips/mips64r6/relocations.s
22–23

Same

This revision is now accepted and ready to land.May 23 2014, 3:25 AM
jkolek closed this revision.May 27 2014, 8:06 AM
jkolek updated this revision to Diff 9839.

Closed by commit rL209659 (authored by zjovanovic).

jkolek edited edge metadata.Nov 18 2014, 5:53 AM
jkolek added a subscriber: Unknown Object (MLST).