This is an archive of the discontinued LLVM Phabricator instance.

Differential D3538

XCore target: fix handling of -g0 flag
ClosedPublic

Authored by robertlytton on Apr 29 2014, 6:10 AM.

Details

Reviewers
• friedgold
Summary

All -g* flags were setting -g in the assembler.
The -g0 flag should not cause a -g.

Diff Detail

Event Timeline

robertlytton updated this revision to Diff 8915.Apr 29 2014, 6:10 AM
robertlytton retitled this revision from to XCore target: fix handling of -g0 flag.
robertlytton updated this object.
robertlytton edited the test plan for this revision. (Show Details)
robertlytton added a reviewer: • friedgold.
robertlytton added a subscriber: Unknown Object (MLST).
• friedgold accepted this revision.May 1 2014, 3:40 AM
• friedgold edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 1 2014, 3:40 AM
robertlytton closed this revision.May 9 2014, 3:34 AM

Revision Contents

PathSize
lib/
Driver/
5 lines
test/
Driver/
5 lines

Diff 8915

lib/Driver/Tools.cpp

Context not available.
if (Args.hasArg(options::OPT_v)) if (Args.hasArg(options::OPT_v))
CmdArgs.push_back("-v"); CmdArgs.push_back("-v");
if (Args.hasArg(options::OPT_g_Group)) if (Arg *A = Args.getLastArg(options::OPT_g_Group))
CmdArgs.push_back("-g"); if (!A->getOption().matches(options::OPT_g0))
CmdArgs.push_back("-g");
if (Args.hasFlag(options::OPT_fverbose_asm, options::OPT_fno_verbose_asm, if (Args.hasFlag(options::OPT_fverbose_asm, options::OPT_fno_verbose_asm,
false)) false))
Context not available.

test/Driver/xcore-opts.c

// RUN: %clang -target xcore %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s // RUN: %clang -target xcore %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s
// RUN: %clang -target xcore -x c++ %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s // RUN: %clang -target xcore -x c++ %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s
// RUN: %clang -target xcore -x c++ %s -fexceptions -### -o %t.o 2>&1 | FileCheck -check-prefix CHECK-EXCEP %s // RUN: %clang -target xcore -x c++ %s -fexceptions -### -o %t.o 2>&1 | FileCheck -check-prefix CHECK-EXCEP %s
// RUN: %clang -target xcore %s -g0 -### -o %t.o 2>&1 | FileCheck -check-prefix CHECK-G0 %s
// CHECK: "-nostdsysteminc" // CHECK: "-nostdsysteminc"
// CHECK: "-momit-leaf-frame-pointer" // CHECK: "-momit-leaf-frame-pointer"
Context not available.
// CHECK-EXCEP: xcc" "-o" // CHECK-EXCEP: xcc" "-o"
// CHECK-EXCEP: "-fexceptions" // CHECK-EXCEP: "-fexceptions"
// CHECK-G0: xcc"
// CHECK-G0-NOT: "-g"
// CHECK-G0: xcc"
Context not available.