Add FreeBSD-specific signal support to elf-core

[emaste]

Summary

Right now elf-core supports only the generic signal set. Override GetUnixSignals in ProcessElfCore, and return the OS-specific signal set, if we have one.

This requires a trivial change to move FreeBSDSignals to Plugins/Process/Utility, not shown in this diff. The equivalent change to support Linux signals in elf-core is straightforward, but we don't (yet) identify Linux cores in a foolproof way.

[• tpoechtrager]

Looks fine.

[emaste]

Closed by commit rL206469 (authored by @emaste).

lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h

public:
 
     //------------------------------------------------------------------
     // Process Queries
     //------------------------------------------------------------------
     virtual bool
     IsAlive ();
 
     //------------------------------------------------------------------
+    // Process Signals
+    //------------------------------------------------------------------
+    virtual lldb_private::UnixSignals &
+    GetUnixSignals()
+    {
+        if (m_signals_sp)
+            return *m_signals_sp;
+        else
+            return Process::GetUnixSignals();
+    }
+
+    //------------------------------------------------------------------
     // Process Memory
     //------------------------------------------------------------------
     virtual size_t
     ReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error);
 
     virtual size_t
     DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error);
 
private:
     typedef lldb_private::Range<lldb::addr_t, lldb::addr_t> FileRange;
     typedef lldb_private::RangeDataArray<lldb::addr_t, lldb::addr_t, FileRange, 1> VMRangeToFileOffset;
 
     lldb::ModuleSP m_core_module_sp;
     lldb_private::FileSpec m_core_file;
     std::string  m_dyld_plugin_name;
     DISALLOW_COPY_AND_ASSIGN (ProcessElfCore);
 
+    llvm::Triple::OSType m_os;
+    std::shared_ptr<lldb_private::UnixSignals> m_signals_sp;
+
     // True if m_thread_contexts contains valid entries
     bool m_thread_data_valid;
 
     // Contain thread data read from NOTE segments
     std::vector<ThreadData> m_thread_data;
 
     // AUXV structure found from the NOTE segment
     lldb_private::DataExtractor m_auxv;

lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp

 #include "lldb/Core/Log.h"
 #include "lldb/Target/Target.h"
 #include "lldb/Target/DynamicLoader.h"
 
 #include "llvm/Support/ELF.h"
 
 #include "Plugins/ObjectFile/ELF/ObjectFileELF.h"
 #include "Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h"
+#include "Plugins/Process/Utility/FreeBSDSignals.h"
 
 // Project includes
 #include "ProcessElfCore.h"
 #include "ThreadElfCore.h"
 
 using namespace lldb_private;
 
 ConstString

 // ProcessElfCore constructor
 //----------------------------------------------------------------------
 ProcessElfCore::ProcessElfCore(Target& target, Listener &listener,
                                const FileSpec &core_file) :
     Process (target, listener),
     m_core_module_sp (),
     m_core_file (core_file),
     m_dyld_plugin_name (),
+    m_os(llvm::Triple::UnknownOS),
+    m_signals_sp (),
     m_thread_data_valid(false),
     m_thread_data(),
     m_core_aranges ()
 {
 }
 
 //----------------------------------------------------------------------
 // Destructor
if (!ranges_are_sorted)
         m_core_aranges.Sort();
 
     // Even if the architecture is set in the target, we need to override
     // it to match the core file which is always single arch.
     ArchSpec arch (m_core_module_sp->GetArchitecture());
     if (arch.IsValid())
         m_target.SetArchitecture(arch);
 
+    switch (m_os)
+    {
+        case llvm::Triple::FreeBSD:
+            m_signals_sp.reset(new FreeBSDSignals());
+            break;
+        default:
+            break;
+    }
+
     return error;
 }
 
 lldb_private::DynamicLoader *
 ProcessElfCore::GetDynamicLoader ()
 {
     if (m_dyld_ap.get() == NULL)
         m_dyld_ap.reset (DynamicLoader::FindPlugin(this, DynamicLoaderPOSIXDYLD::GetPluginNameStatic().GetCString()));
ProcessElfCore::DoReadMemory (lldb::addr_t addr, void *buf, size_t size, Error &error)
 
     return bytes_copied + zero_fill_size;
 }
 
 void
 ProcessElfCore::Clear()
 {
     m_thread_list.Clear();
+    m_os = llvm::Triple::UnknownOS;
+    m_signals_sp.reset();
 }
 
 void
 ProcessElfCore::Initialize()
 {
     static bool g_initialized = false;
 
     if (g_initialized == false)
while (offset < segment_header->p_filesz)
         size_t note_start, note_size;
         note_start = offset;
         note_size = llvm::RoundUpToAlignment(note.n_descsz, 4);
 
         // Store the NOTE information in the current thread
         DataExtractor note_data (segment_data, note_start, note_size);
         if (note.n_name == "FreeBSD")
         {
+            m_os = llvm::Triple::FreeBSD;
             switch (note.n_type)
             {
                 case NT_FREEBSD_PRSTATUS:
                     have_prstatus = true;
                     ParseFreeBSDPrStatus(*thread_data, note_data, arch);
                     break;
                 case NT_FREEBSD_FPREGSET:
                     thread_data->fpregset = note_data;