This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] replace bzero with memset
ClosedPublic

Authored by jroelofs on Apr 15 2014, 2:05 PM.

Details

Reviewers
jroelofs
nlewycky
Summary

For support of newlib as the c library.

Diff Detail

Event Timeline

joerg added a comment.Apr 15 2014, 2:47 PM

Please split the changes into two separate patches. The memset part is fine for commit. The ARM changes are not (yet).

kledzik added inline comments.Apr 15 2014, 4:52 PM
src/Unwind/Registers.hpp
1549

Why add the parameter name? Not having the name suppresses "unused variable" messages.

Ok, I'll split out the memset bit from the arm stuff (and hold off on that part for now).

jroelofs updated this revision to Unknown Object (????).Apr 16 2014, 3:07 PM

Removed the arm bits for now.

LGTM please commit.

Committed r206427

jroelofs accepted this revision.May 6 2014, 3:08 PM
jroelofs added a reviewer: jroelofs.
This revision is now accepted and ready to land.May 6 2014, 3:08 PM
jroelofs closed this revision.May 6 2014, 3:08 PM