This is an archive of the discontinued LLVM Phabricator instance.

Differential D32303

Define a suppression for known leaks on pthread_exit call.
ClosedPublic

Authored by alekseyshl on Apr 20 2017, 11:02 AM.

Details

Reviewers
eugenis
Commits
rGbdbb894a5299: Define a suppression for known leaks on pthread_exit call.
rCRT300886: Define a suppression for known leaks on pthread_exit call.
rL300886: Define a suppression for known leaks on pthread_exit call.
Summary

Refer to D32194 for the context.

Diff Detail

Event Timeline

alekseyshl created this revision.Apr 20 2017, 11:02 AM
Herald added a subscriber: kubamracek. · View Herald TranscriptApr 20 2017, 11:02 AM
eugenis added inline comments.Apr 20 2017, 11:10 AM
lib/lsan/lsan_common.cc
854

This way the suppression is lost when the user overrides __lsan_default_suppressions, which is exactly what it is for.

alekseyshl updated this revision to Diff 96007.Apr 20 2017, 1:35 PM
  • Define standard suppressions for LSan, start with this one.
Harbormaster completed remote builds in B5719: Diff 96007.Apr 20 2017, 1:35 PM
alekseyshl marked an inline comment as done.Apr 20 2017, 1:36 PM
eugenis accepted this revision.Apr 20 2017, 1:58 PM

LGTM

This revision is now accepted and ready to land.Apr 20 2017, 1:58 PM
Closed by commit rL300886: Define a suppression for known leaks on pthread_exit call. (authored by alekseyshl). · Explain WhyApr 20 2017, 2:14 PM
This revision was automatically updated to reflect the committed changes.
alekseyshl mentioned this in D32314: Enable LSan on PowerPC64..Apr 20 2017, 3:00 PM
alekseyshl mentioned this in rL300903: Enable LSan on PowerPC64..Apr 20 2017, 3:14 PM
alekseyshl mentioned this in D32379: [lsan] Enable LSan on PowerPC64..Apr 21 2017, 2:59 PM
alekseyshl mentioned this in rL301048: [lsan] Enable LSan on PowerPC64..Apr 21 2017, 3:12 PM

Revision Contents

PathSize
lib/
asan/
tests/
9 lines
lsan/
6 lines
sanitizer_common/
11 lines

Diff 95985

lib/asan/tests/asan_test_main.cc

Show All 16 Lines
extern "C" const char* __asan_default_options() { extern "C" const char* __asan_default_options() {
#if SANITIZER_MAC #if SANITIZER_MAC
// On Darwin, we default to `abort_on_error=1`, which would make tests run // On Darwin, we default to `abort_on_error=1`, which would make tests run
// much slower. Let's override this and run lit tests with 'abort_on_error=0' // much slower. Let's override this and run lit tests with 'abort_on_error=0'
// and make sure we do not overwhelm the syslog while testing. Also, let's // and make sure we do not overwhelm the syslog while testing. Also, let's
// turn symbolization off to speed up testing, especially when not running // turn symbolization off to speed up testing, especially when not running
// with llvm-symbolizer but with atos. // with llvm-symbolizer but with atos.
return "symbolize=false:abort_on_error=0:log_to_syslog=0"; return "symbolize=false:abort_on_error=0:log_to_syslog=0";
#elif SANITIZER_PPC || defined(__thumb__) #elif SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT
// On PowerPC and ARM Thumb, a couple tests involving pthread_exit fail due to // On PowerPC and ARM Thumb, a couple tests involving pthread_exit fail due to
// leaks detected by LSan. pthread_exit tries to perform unwinding that leads // leaks detected by LSan. Symbolized leak report is required to apply a
// to dlopen'ing libgcc_s.so. dlopen mallocs "libgcc_s.so" string which // suppression for this known problem.
// confuses LSan, it fails to realize that this allocation happens in dynamic
// linker and should be ignored. Symbolized leak report is required to define
// a suppression for this known problem.
return ""; return "";
#else #else
// Let's turn symbolization off to speed up testing (more than 3 times speedup // Let's turn symbolization off to speed up testing (more than 3 times speedup
// observed). // observed).
return "symbolize=false"; return "symbolize=false";
#endif #endif
} }
Show All 20 Lines

lib/lsan/lsan_common.cc

Show First 20 Lines • Show All 842 Lines • ▼ Show 20 Lines
#if !SANITIZER_SUPPORTS_WEAK_HOOKS #if !SANITIZER_SUPPORTS_WEAK_HOOKS
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
int __lsan_is_turned_off() { int __lsan_is_turned_off() {
return 0; return 0;
} }
SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
const char *__lsan_default_suppressions() { const char *__lsan_default_suppressions() {
#if SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT
// The actual string allocation happens here (for more details refer to the
// SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT definition).
return "leak:*_dl_map_object_deps*";
eugenisUnsubmitted
Done
ReplyInline Actions

This way the suppression is lost when the user overrides __lsan_default_suppressions, which is exactly what it is for.

eugenis: This way the suppression is lost when the user overrides __lsan_default_suppressions, which is…
#else
return ""; return "";
#endif // SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT
} }
#endif #endif
} // extern "C" } // extern "C"

lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 253 Lines • ▼ Show 20 Lines
#if SANITIZER_LINUX && (SANITIZER_S390 || SANITIZER_PPC32 || SANITIZER_PPC64V1) #if SANITIZER_LINUX && (SANITIZER_S390 || SANITIZER_PPC32 || SANITIZER_PPC64V1)
#define SANITIZER_NLDBL_VERSION "GLIBC_2.4" #define SANITIZER_NLDBL_VERSION "GLIBC_2.4"
#endif #endif
#if SANITIZER_GO == 0 #if SANITIZER_GO == 0
# define SANITIZER_GO 0 # define SANITIZER_GO 0
#endif #endif
// On PowerPC and ARM Thumb, calling pthread_exit() causes LSan to detect leaks.
// pthread_exit() performs unwinding that leads to dlopen'ing libgcc_s.so.
// dlopen mallocs "libgcc_s.so" string which confuses LSan, it fails to realize
// that this allocation happens in dynamic linker and should be ignored.
#if SANITIZER_PPC || defined(__thumb__)
# define SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT 1
#else
# define SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT 0
#endif
#endif // SANITIZER_PLATFORM_H #endif // SANITIZER_PLATFORM_H