This is an archive of the discontinued LLVM Phabricator instance.

LLDB Python API support on Windows (ported the SWIG wrapper shell scripts to Python)
Needs ReviewPublic

Authored by deepak2427 on Mar 6 2014, 3:16 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch will create a valid Python API for Windows, pending some issues. The changes included are -

  • Ported the SWIG wrapper shell scripts to Python so that they would work on Windows too along with other platforms
  • Updated CMake handling to fix SWIG errors and manage sym-linking on Windows to liblldb.dll
  • More build fixes for Windows

The pending issues are that two Python modules, termios and pexpect are not available on Windows.
We have to work on this issue, by either removing this dependency or working around it.

Once these issues are dealt with, we would be able to run the Python test suite on Windows.

Diff Detail

Event Timeline

emaste added inline comments.Mar 10 2014, 11:49 AM
scripts/Python/buildSwigPython.py
1

Missing FreeBSD here; probably best to just not list platforms at all.
(Same comment applies to several files)

9

Same comment as above, and "IDE" on the next line seems odd -- presumably PTVS isn't needed on non-Windows platforms :)

(Same comment applies to several files)

scripts/Python/finish-swig-Python-LLDB.sh
159

accidental whitespace change?

scripts/Python/finishSwigPythonLLDB.py
38

Recommend putting in the standard copyright & license notice instead

scripts/utilsDebug.py
134

whitespace issue

source/Interpreter/ScriptInterpreterPython.cpp
704

it's too bad that phabricator is confused by the indentation; is the only change the addition of the namespace?