[COMPILER-RT] Implement __extendsftf2, __extenddftf2

[koviankevin]

Summary

Implement extendsftf2, extenddftf2, which extend float or double type to long double

[gribozavr]

A common comment for all your recent compiler-rt patches: could you please add tests?

[koviankevin]

OK, we will add tests and update our patch

[koviankevin]

add test

[gribozavr]

Please note the other comment by Joerg that it is more idiomatic to change these header files to .inc files that would be used like:

#define NAME runtimefuncf
#include "runtimefunc_impl.inc"

This avoids ugly '\' markers in the implementation, and brings back source highlighting in editors.

test/builtins/Unit/extenddftf2_test.c

24–25 ↗

(On Diff #7229)

This is not testing much... If (long double) conversion is implemented as a call to the runtime library, this could be just calling back to the installed version of compiler-rt.

[koviankevin]

Use CRT_HAS_128BIT and modify the codes according to gribozavr's comments

[koviankevin]

introduce CRT_LDBL_128BIT

[koviankevin]

modify by gribozavr's comment and use COMPILER_RT_ABI

[koviankevin]

use UINT64_C and drop le64
extendsfdf2.c is refactored in D3887

[joerg]

Closed by commit rL209783 (authored by @joerg).

compiler-rt/trunk/lib/builtins/extenddftf2.c

+//===-- lib/extenddftf2.c - double -> quad conversion -------------*- C -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+
+#define QUAD_PRECISION
+#include "fp_lib.h"
+
+#if defined(CRT_HAS_128BIT) && defined(CRT_LDBL_128BIT)
+#define SRC_DOUBLE
+#define DST_QUAD
+#include "fp_extend_impl.inc"
+
+COMPILER_RT_ABI long double __extenddftf2(double a) {
+    return __extendXfYf2__(a);
+}
+
+#endif

compiler-rt/trunk/lib/builtins/extendsftf2.c

+//===-- lib/extendsftf2.c - single -> quad conversion -------------*- C -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+
+#define QUAD_PRECISION
+#include "fp_lib.h"
+
+#if defined(CRT_HAS_128BIT) && defined(CRT_LDBL_128BIT)
+#define SRC_SINGLE
+#define DST_QUAD
+#include "fp_extend_impl.inc"
+
+COMPILER_RT_ABI long double __extendsftf2(float a) {
+    return __extendXfYf2__(a);
+}
+
+#endif

compiler-rt/trunk/test/builtins/Unit/extenddftf2_test.c

+//===--------------- extenddftf2_test.c - Test __extenddftf2 --------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file tests __extenddftf2 for the compiler_rt library.
+//
+//===----------------------------------------------------------------------===//
+
+#include <stdio.h>
+
+#if __LDBL_MANT_DIG__ == 113
+
+#include "fp_test.h"
+
+long double __extenddftf2(double a);
+
+int test__extenddftf2(double a, uint64_t expectedHi, uint64_t expectedLo)
+{
+    long double x = __extenddftf2(a);
+    int ret = compareResultLD(x, expectedHi, expectedLo);
+
+    if (ret){
+        printf("error in test__extenddftf2(%f) = %.20Lf, "
+               "expected %.20Lf\n", a, x, fromRep128(expectedHi, expectedLo));
+    }
+    return ret;
+}
+
+char assumption_1[sizeof(long double) * CHAR_BIT == 128] = {0};
+
+#endif
+
+int main()
+{
+#if __LDBL_MANT_DIG__ == 113
+    // qNaN
+    if (test__extenddftf2(makeQNaN64(),
+                          UINT64_C(0x7fff800000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // NaN
+    if (test__extenddftf2(makeNaN64(UINT64_C(0x7100000000000)),
+                          UINT64_C(0x7fff710000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // inf
+    if (test__extenddftf2(makeInf64(),
+                          UINT64_C(0x7fff000000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // zero
+    if (test__extenddftf2(0.0, UINT64_C(0x0), UINT64_C(0x0)))
+        return 1;
+
+    if (test__extenddftf2(0x1.23456789abcdefp+5,
+                          UINT64_C(0x400423456789abcd),
+                          UINT64_C(0xf000000000000000)))
+        return 1;
+    if (test__extenddftf2(0x1.edcba987654321fp-9,
+                          UINT64_C(0x3ff6edcba9876543),
+                          UINT64_C(0x2000000000000000)))
+        return 1;
+    if (test__extenddftf2(0x1.23456789abcdefp+45,
+                          UINT64_C(0x402c23456789abcd),
+                          UINT64_C(0xf000000000000000)))
+        return 1;
+    if (test__extenddftf2(0x1.edcba987654321fp-45,
+                          UINT64_C(0x3fd2edcba9876543),
+                          UINT64_C(0x2000000000000000)))
+        return 1;
+
+#else
+    printf("skipped\n");
+
+#endif
+    return 0;
+}

compiler-rt/trunk/test/builtins/Unit/extendsftf2_test.c

+//===--------------- extendsftf2_test.c - Test __extendsftf2 --------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file tests __extendsftf2 for the compiler_rt library.
+//
+//===----------------------------------------------------------------------===//
+
+#include <stdio.h>
+
+#if __LDBL_MANT_DIG__ == 113
+
+#include "fp_test.h"
+
+long double __extendsftf2(float a);
+
+int test__extendsftf2(float a, uint64_t expectedHi, uint64_t expectedLo)
+{
+    long double x = __extendsftf2(a);
+    int ret = compareResultLD(x, expectedHi, expectedLo);
+
+    if (ret)
+    {
+        printf("error in test__extendsftf2(%f) = %.20Lf, "
+               "expected %.20Lf\n", a, x, fromRep128(expectedHi, expectedLo));
+    }
+    return ret;
+}
+
+char assumption_1[sizeof(long double) * CHAR_BIT == 128] = {0};
+
+#endif
+
+int main()
+{
+#if __LDBL_MANT_DIG__ == 113
+    // qNaN
+    if (test__extendsftf2(makeQNaN32(),
+                          UINT64_C(0x7fff800000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // NaN
+    if (test__extendsftf2(makeNaN32(UINT32_C(0x410000)),
+                          UINT64_C(0x7fff820000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // inf
+    if (test__extendsftf2(makeInf32(),
+                          UINT64_C(0x7fff000000000000),
+                          UINT64_C(0x0)))
+        return 1;
+    // zero
+    if (test__extendsftf2(0.0f, UINT64_C(0x0), UINT64_C(0x0)))
+        return 1;
+
+    if (test__extendsftf2(0x1.23456p+5f,
+                          UINT64_C(0x4004234560000000),
+                          UINT64_C(0x0)))
+        return 1;
+    if (test__extendsftf2(0x1.edcbap-9f,
+                          UINT64_C(0x3ff6edcba0000000),
+                          UINT64_C(0x0)))
+        return 1;
+    if (test__extendsftf2(0x1.23456p+45f,
+                          UINT64_C(0x402c234560000000),
+                          UINT64_C(0x0)))
+        return 1;
+    if (test__extendsftf2(0x1.edcbap-45f,
+                          UINT64_C(0x3fd2edcba0000000),
+                          UINT64_C(0x0)))
+        return 1;
+
+#else
+    printf("skipped\n");
+
+#endif
+    return 0;
+}