This is an archive of the discontinued LLVM Phabricator instance.

Fix arguments of trace output in __kmp_push_stack
ClosedPublic

Authored by vhscampos on Dec 9 2016, 5:40 PM.

Diff Detail

Event Timeline

vhscampos updated this revision to Diff 80985.Dec 9 2016, 5:40 PM
vhscampos retitled this revision from to Fix arguments of trace output in __kmp_push_stack.
vhscampos updated this object.
vhscampos added a subscriber: openmp-commits.

Good catch!

Could you also move the KA_TRACE statement above the __kmp_release_bootstrap_lock(). Because currently the printed data may not be related to the pushed task if some other task is pushed between lock releasing and the print itself. Having the print inside critical section would guarantee the relevant data printed.

Thanks, Andrey

vhscampos updated this revision to Diff 81125.Dec 12 2016, 12:20 PM
vhscampos edited edge metadata.

Moved trace call inside the critical section.

AndreyChurbanov accepted this revision.Dec 13 2016, 12:19 AM
AndreyChurbanov edited edge metadata.

LGTM

Shell I commit the patch on your behalf?

This revision is now accepted and ready to land.Dec 13 2016, 12:19 AM
This revision was automatically updated to reflect the committed changes.