R600/SI: Use isProfitableToDupForIfCvt

[arsenm]

Summary

It was only being used by R600

[arsenm]

Ping

[arsenm]

Ping

[arsenm]

Needs to be redone with knowledge of uniform branches

lib/Target/R600/AMDGPUInstrInfo.h

 
   virtual const AMDGPURegisterInfo &getRegisterInfo() const = 0;
 
+  virtual bool
+  isProfitableToIfCvt(MachineBasicBlock &MBB, unsigned NumCycles,
+                      unsigned ExtraPredCycles,
+                      const BranchProbability &Probability) const LLVM_OVERRIDE;
+
+  virtual bool isProfitableToIfCvt(
+    MachineBasicBlock &TMBB,
+    unsigned NumTCycles, unsigned ExtraTCycles,
+    MachineBasicBlock &FMBB,
+    unsigned NumFCycles, unsigned ExtraFCycles,
+    const BranchProbability &Probability) const LLVM_OVERRIDE;
+
+  virtual bool
+  isProfitableToDupForIfCvt(MachineBasicBlock &, unsigned,
+                            const BranchProbability &) const LLVM_OVERRIDE;
+
+  virtual bool
+  isProfitableToUnpredicate(MachineBasicBlock &,
+                            MachineBasicBlock &) const LLVM_OVERRIDE;
+
+
   bool isCoalescableExtInstr(const MachineInstr &MI, unsigned &SrcReg,
                              unsigned &DstReg, unsigned &SubIdx) const;
 

lib/Target/R600/AMDGPUInstrInfo.cpp

   return RI;
 }
 
+bool AMDGPUInstrInfo::isProfitableToIfCvt(MachineBasicBlock &,
+                                          unsigned, unsigned,
+                                          const BranchProbability &) const {
+  return true;
+}
+
+bool AMDGPUInstrInfo::isProfitableToIfCvt(MachineBasicBlock &,
+                                          unsigned, unsigned,
+                                          MachineBasicBlock &,
+                                          unsigned, unsigned,
+                                          const BranchProbability &) const {
+  return true;
+}
+
+bool AMDGPUInstrInfo::isProfitableToDupForIfCvt(
+  MachineBasicBlock &, unsigned,
+  const BranchProbability &) const {
+  return true;
+}
+
+bool AMDGPUInstrInfo::isProfitableToUnpredicate(MachineBasicBlock &,
+                                                MachineBasicBlock &) const {
+  return true;
+}
+
 bool AMDGPUInstrInfo::isCoalescableExtInstr(const MachineInstr &MI,
                                            unsigned &SrcReg, unsigned &DstReg,
                                            unsigned &SubIdx) const {

lib/Target/R600/R600InstrInfo.h

 
   bool isPredicable(MachineInstr *MI) const;
 
-  bool
-   isProfitableToDupForIfCvt(MachineBasicBlock &MBB, unsigned NumCyles,
-                             const BranchProbability &Probability) const;
-
-  bool isProfitableToIfCvt(MachineBasicBlock &MBB, unsigned NumCyles,
-                           unsigned ExtraPredCycles,
-                           const BranchProbability &Probability) const ;
-
-  bool
-   isProfitableToIfCvt(MachineBasicBlock &TMBB,
-                       unsigned NumTCycles, unsigned ExtraTCycles,
-                       MachineBasicBlock &FMBB,
-                       unsigned NumFCycles, unsigned ExtraFCycles,
-                       const BranchProbability &Probability) const;
-
   bool DefinesPredicate(MachineInstr *MI,
                                   std::vector<MachineOperand> &Pred) const;
 
   bool SubsumesPredicate(const SmallVectorImpl<MachineOperand> &Pred1,
                          const SmallVectorImpl<MachineOperand> &Pred2) const;
 
-  bool isProfitableToUnpredicate(MachineBasicBlock &TMBB,
-                                          MachineBasicBlock &FMBB) const;
-
   bool PredicateInstruction(MachineInstr *MI,
                         const SmallVectorImpl<MachineOperand> &Pred) const;
 

lib/Target/R600/R600InstrInfo.cpp

   }
 }
 
-
-bool
-R600InstrInfo::isProfitableToIfCvt(MachineBasicBlock &MBB,
-                                   unsigned NumCyles,
-                                   unsigned ExtraPredCycles,
-                                   const BranchProbability &Probability) const{
-  return true;
-}
-
-bool
-R600InstrInfo::isProfitableToIfCvt(MachineBasicBlock &TMBB,
-                                   unsigned NumTCycles,
-                                   unsigned ExtraTCycles,
-                                   MachineBasicBlock &FMBB,
-                                   unsigned NumFCycles,
-                                   unsigned ExtraFCycles,
-                                   const BranchProbability &Probability) const {
-  return true;
-}
-
-bool
-R600InstrInfo::isProfitableToDupForIfCvt(MachineBasicBlock &MBB,
-                                         unsigned NumCyles,
-                                         const BranchProbability &Probability)
-                                         const {
-  return true;
-}
-
-bool
-R600InstrInfo::isProfitableToUnpredicate(MachineBasicBlock &TMBB,
-                                         MachineBasicBlock &FMBB) const {
-  return false;
-}
-
-
 bool
 R600InstrInfo::ReverseBranchCondition(SmallVectorImpl<MachineOperand> &Cond) const {
   MachineOperand &MO = Cond[1];