This is an archive of the discontinued LLVM Phabricator instance.

Fix error in tablegen when second operand of an !if is an empty list.
ClosedPublic

Authored by arsenm on Feb 7 2014, 3:00 PM.

Details

Reviewers
arsenm
Summary

!if([Something], []) would error with "No type for list".

Diff Detail

Event Timeline

arsenm updated this revision to Unknown Object (????).Feb 18 2014, 4:18 PM

Add test. I didn't know there were any tests for tablegen before.

arsenm updated this revision to Diff 9979.May 30 2014, 10:24 PM

Replace with a simpler fix that also handles an empty list as either result operand

arsenm accepted this revision.Jun 10 2014, 1:18 PM
arsenm added a reviewer: arsenm.

r210572

This revision is now accepted and ready to land.Jun 10 2014, 1:18 PM
arsenm closed this revision.Jun 10 2014, 1:18 PM