This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Fix VisualStudio virtual folders layout
ClosedPublic

Authored by etienneb on Jul 1 2016, 9:22 PM.

Details

Summary

This patch is a refactoring of the way cmake 'targets' are grouped.
It won't affect non-UI cmake-generators.

Clang/LLVM are using a structured way to group targets which ease
navigation through Visual Studio UI. The Compiler-RT projects
differ from the way Clang/LLVM are grouping targets.

This patch doesn't contain behavior changes.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 62600.Jul 1 2016, 9:22 PM
etienneb retitled this revision from to [compiler-rt] Fix VisualStudio virtual folders layout.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb updated this revision to Diff 62601.Jul 1 2016, 9:25 PM

fix nits

rnk edited edge metadata.

I think Kuba uses the XCode build, so he might be a better reviewer for this.

test/asan/CMakeLists.txt
106

Not "Compiler-RT Tests"?

120

ditto, and the other test targets below

etienneb added inline comments.Jul 6 2016, 8:39 AM
test/asan/CMakeLists.txt
106

The reason it's like that is to group the "Executables" together.
So, under "Compiler-RT tests" you have executables.
The "Misc" is used for the PHONY rules.

I don't have a strong opinion on where we should put them.

etienneb updated this object.Jul 6 2016, 8:38 PM
etienneb edited edge metadata.
rnk accepted this revision.Jul 11 2016, 2:18 PM
rnk edited edge metadata.

lgtm Kuba, let us know if you don't like the new layout.

test/asan/CMakeLists.txt
106

Sounds reasonable, I guess we can keep it in misc.

This revision is now accepted and ready to land.Jul 11 2016, 2:18 PM
etienneb closed this revision.Jul 11 2016, 2:59 PM