This is an archive of the discontinued LLVM Phabricator instance.

Do not count debug instructions when counting number of uses to reorder frame objects.
ClosedPublic

Authored by danielcdh on Jun 30 2016, 4:11 PM.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 62436.Jun 30 2016, 4:11 PM
danielcdh retitled this revision from to Do not count debug instructions when counting number of uses to reorder frame objects..
danielcdh updated this object.
danielcdh added reviewers: zansari, davidxl, mkuper.
danielcdh added a subscriber: llvm-commits.
majnemer requested changes to this revision.Jun 30 2016, 4:18 PM
majnemer added a reviewer: majnemer.
majnemer added a subscriber: majnemer.

The change looks fine but you will need to add a test case.

This revision now requires changes to proceed.Jun 30 2016, 4:18 PM
majnemer added inline comments.Jun 30 2016, 4:19 PM
test/DebugInfo/COFF/local-variables.ll
30–59

It would probably be a good idea to capture 52, 44 and 48 in FileCheck variables so that the test is less sensitive to changes.

danielcdh updated this revision to Diff 62442.Jun 30 2016, 4:49 PM
danielcdh edited edge metadata.

add test and update existing test with variable.

majnemer added inline comments.Jun 30 2016, 5:59 PM
test/DebugInfo/COFF/local-variables.ll
30–60

You should use these variables down below

danielcdh added inline comments.Jun 30 2016, 6:25 PM
test/DebugInfo/COFF/local-variables.ll
30–60

The tests down below are separate tests (OBJ v.s. ASM), and these variables has no reuse in that test. So do you mean that I do not check these offset values at all in the OBJ tests? I can remove the check for numbers if that is what you meant.

majnemer accepted this revision.Jun 30 2016, 6:30 PM
majnemer edited edge metadata.

LGTM with the suggested changes to local-variables.ll undone.

test/DebugInfo/COFF/local-variables.ll
30–60

Ah, nevermind. In that case the test is better off with an explicit offset... Sorry about that!

This revision is now accepted and ready to land.Jun 30 2016, 6:30 PM
danielcdh updated this revision to Diff 62454.Jun 30 2016, 6:37 PM
danielcdh edited edge metadata.

undo changes in local-variables.ll

danielcdh closed this revision.Jul 1 2016, 8:47 AM