This is an archive of the discontinued LLVM Phabricator instance.

Differential D21862

[compiler-rt] Fix the Asan unittest on Windows
ClosedPublic

Authored by etienneb on Jun 29 2016, 2:53 PM.

Details

Reviewers
rnk
Commits
rG30ece958dbf3: [compiler-rt] Fix the Asan unittest on Windows
rCRT274172: [compiler-rt] Fix the Asan unittest on Windows
rL274172: [compiler-rt] Fix the Asan unittest on Windows
Summary

The build bot is broken because the runtime library doesn't have
debug information.

This is broken due to a recent change:

http://reviews.llvm.org/D21554

Diff Detail

Event Timeline

etienneb updated this revision to Diff 62288.Jun 29 2016, 2:53 PM
etienneb retitled this revision from to [compiler-rt] Fix the Asan unittest on Windows.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb added subscribers: • chrisha, llvm-commits.
Herald added a subscriber: kubamracek. · View Herald TranscriptJun 29 2016, 2:53 PM
rnk accepted this revision.Jun 29 2016, 3:00 PM
rnk edited edge metadata.

Lgtm

This revision is now accepted and ready to land.Jun 29 2016, 3:00 PM
etienneb closed this revision.Jun 29 2016, 3:01 PM

Revision Contents

PathSize
lib/
asan/
2 lines

Diff 62288

lib/asan/CMakeLists.txt

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
set(ASAN_DYNAMIC_DEFINITIONS set(ASAN_DYNAMIC_DEFINITIONS
${ASAN_COMMON_DEFINITIONS} ASAN_DYNAMIC=1) ${ASAN_COMMON_DEFINITIONS} ASAN_DYNAMIC=1)
append_list_if(WIN32 INTERCEPTION_DYNAMIC_CRT ASAN_DYNAMIC_DEFINITIONS) append_list_if(WIN32 INTERCEPTION_DYNAMIC_CRT ASAN_DYNAMIC_DEFINITIONS)
set(ASAN_DYNAMIC_CFLAGS ${ASAN_CFLAGS}) set(ASAN_DYNAMIC_CFLAGS ${ASAN_CFLAGS})
append_list_if(COMPILER_RT_HAS_FTLS_MODEL_INITIAL_EXEC append_list_if(COMPILER_RT_HAS_FTLS_MODEL_INITIAL_EXEC
-ftls-model=initial-exec ASAN_DYNAMIC_CFLAGS) -ftls-model=initial-exec ASAN_DYNAMIC_CFLAGS)
append_list_if(MSVC /DEBUG ASAN_DYNAMIC_CFLAGS) append_list_if(MSVC /DEBUG ASAN_DYNAMIC_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_LIBC c ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBC c ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBDL dl ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBDL dl ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBRT rt ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBRT rt ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBM m ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBM m ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBSTDCXX stdc++ ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBSTDCXX stdc++ ASAN_DYNAMIC_LIBS)
append_list_if(COMPILER_RT_HAS_LIBLOG log ASAN_DYNAMIC_LIBS) append_list_if(COMPILER_RT_HAS_LIBLOG log ASAN_DYNAMIC_LIBS)
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines