This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove superfluous string attributes from tests
ClosedPublic

Authored by arsenm on Jun 27 2016, 11:53 AM.

Details

Summary

Also fix v_mac.ll not testing right thing for fneg

Diff Detail

Event Timeline

arsenm updated this revision to Diff 61996.Jun 27 2016, 11:53 AM
arsenm retitled this revision from to AMDGPU: Remove superfluous string attributes from tests.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
nhaehnle accepted this revision.Jul 6 2016, 1:33 AM
nhaehnle added a reviewer: nhaehnle.
nhaehnle added a subscriber: nhaehnle.

Apart from some minor comments, LGTM.

test/CodeGen/AMDGPU/fmul.ll
1

Isn't it better to be explicit about -mcpu? Not that I care strongly either way...

test/CodeGen/AMDGPU/llvm.SI.sendmsg-m0.ll
17–19

Now #1 is missing in the sendmsg declare, isn't it?

test/CodeGen/AMDGPU/sgpr-copy.ll
398–400

Duplicate #1 and #3.

This revision is now accepted and ready to land.Jul 6 2016, 1:33 AM
arsenm closed this revision.Jul 11 2016, 4:43 PM
arsenm marked 2 inline comments as done.

r275129

test/CodeGen/AMDGPU/fmul.ll
1

It doesn't really matter, the default is just tahiti. I don't think most tests specify for SI