This is an archive of the discontinued LLVM Phabricator instance.

[MBFI] add edge label with branch probability info
ClosedPublic

Authored by davidxl on Jun 21 2016, 9:53 PM.

Details

Summary

This patch improves the dot cfg dump for BFI with edges labeled with branch probability info. This gives a more complete picture of profiling of a function. It also helps to identify bugs in BFI. This of course can be done under an option, but I think it is better to always show the information as it does not clutter the graph in any way. See http://reviews.llvm.org/F2090394 as an example of BFI graph with BP info.

Diff Detail

Repository
rL LLVM

Event Timeline

davidxl updated this revision to Diff 61501.Jun 21 2016, 9:53 PM
davidxl retitled this revision from to [MBFI] add edge label with branch probability info.
davidxl updated this object.
davidxl added reviewers: danielcdh, silvas.
davidxl added a subscriber: llvm-commits.
silvas accepted this revision.Jun 22 2016, 1:26 AM
silvas edited edge metadata.

Nice! Thanks for the screenshot. LGTM

This revision is now accepted and ready to land.Jun 22 2016, 1:26 AM
This revision was automatically updated to reflect the committed changes.