This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fold more custom nodes to undef
ClosedPublic

Authored by arsenm on Jun 16 2016, 8:59 AM.

Details

Reviewers
tstellarAMD
Summary

This will help sneak undefs past GVN into the DAG for some tests.

Also add missing intrinsic for rsq_legacy, even though the node was already selected to the instruction. Also start passing the debug location to intrinsic errors.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 60984.Jun 16 2016, 8:59 AM
arsenm retitled this revision from to AMDGPU: Fold more custom nodes to undef.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Jun 17 2016, 8:07 PM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jun 17 2016, 8:07 PM
test/CodeGen/AMDGPU/vi-removed-intrinsics.ll
16–24

Is all this necessary?

arsenm added inline comments.Jun 17 2016, 10:11 PM
test/CodeGen/AMDGPU/vi-removed-intrinsics.ll
16–24

Yes. Most of these things are surprisingly required

arsenm closed this revision.Jun 20 2016, 11:41 AM

r273181