This is an archive of the discontinued LLVM Phabricator instance.

Add an Android version check for GNU strerror_r.
ClosedPublic

Authored by danalbert on Jun 15 2016, 1:14 PM.

Details

Summary

Android didn't gain GNU's strerror_r until Marshmallow. If we're
building libc++ against something older (we build the NDK library
against the oldest release we support, currently Gingerbread), fall
back to the POSIX version.

Diff Detail

Repository
rL LLVM

Event Timeline

danalbert updated this revision to Diff 60887.Jun 15 2016, 1:14 PM
danalbert retitled this revision from to Add an Android version check for GNU strerror_r..
danalbert updated this object.
danalbert added reviewers: mclow.lists, EricWF.
danalbert added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 15 2016, 1:19 PM
EricWF edited edge metadata.

LGTM.

I would have preferred to always use the POSIX version, but it's impossible to turn of GNU extensions without breaking the linux build.

This revision is now accepted and ready to land.Jun 15 2016, 1:19 PM
This revision was automatically updated to reflect the committed changes.